Repository navigation
DeleteStateOnClear support for AdoNet storage provider - #8535
Merged
Merged
Conversation
|
Is this going to be added at some point? |
…ovider. -add delete on clear script for postgresql
- Fix SQL Server DeleteStorageKey INSERT to use idempotent WHERE NOT EXISTS pattern consistent with other query inserts in the script - Modernize RelationalStorageProviderQueries to use file-scoped namespace, ArgumentNullException.ThrowIfNull, and proper XML doc comments - Fix comment formatting to follow C# conventions (space after //) - Use nameof() in exception messages instead of string literals - Add CommonFixture.GetStorageProvider overload with deleteStateOnClear param - Add RelationalStorageTests support for deleteStateOnClear - Add SqlServerStorageDeleteOnClearTests for low-level storage tests - Add PostgreSqlStorageDeleteOnClearTests for low-level storage tests - Add PersistenceGrainTests_SqlServer_DeleteStateOnClear for grain-level tests - Add PersistenceGrainTests_Postgres_DeleteStateOnClear for grain-level tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
enabled auto-merge
February 15, 2026 14:01
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 15, 2026
* -add DeleteStateOnClear option and support to AdoNet grain storage provider. -add delete on clear script for postgresql * add delete on clear script for mssql * fix returned version in postgresql delete on clear state script * Fix and improve DeleteStateOnClear support for AdoNet storage provider - Fix SQL Server DeleteStorageKey INSERT to use idempotent WHERE NOT EXISTS pattern consistent with other query inserts in the script - Modernize RelationalStorageProviderQueries to use file-scoped namespace, ArgumentNullException.ThrowIfNull, and proper XML doc comments - Fix comment formatting to follow C# conventions (space after //) - Use nameof() in exception messages instead of string literals - Add CommonFixture.GetStorageProvider overload with deleteStateOnClear param - Add RelationalStorageTests support for deleteStateOnClear - Add SqlServerStorageDeleteOnClearTests for low-level storage tests - Add PostgreSqlStorageDeleteOnClearTests for low-level storage tests - Add PersistenceGrainTests_SqlServer_DeleteStateOnClear for grain-level tests - Add PersistenceGrainTests_Postgres_DeleteStateOnClear for grain-level tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add delete-on-clear support for MySQL and Oracle Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Reuben Bond <reuben.bond@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
* -add DeleteStateOnClear option and support to AdoNet grain storage provider. -add delete on clear script for postgresql * add delete on clear script for mssql * fix returned version in postgresql delete on clear state script * Fix and improve DeleteStateOnClear support for AdoNet storage provider - Fix SQL Server DeleteStorageKey INSERT to use idempotent WHERE NOT EXISTS pattern consistent with other query inserts in the script - Modernize RelationalStorageProviderQueries to use file-scoped namespace, ArgumentNullException.ThrowIfNull, and proper XML doc comments - Fix comment formatting to follow C# conventions (space after //) - Use nameof() in exception messages instead of string literals - Add CommonFixture.GetStorageProvider overload with deleteStateOnClear param - Add RelationalStorageTests support for deleteStateOnClear - Add SqlServerStorageDeleteOnClearTests for low-level storage tests - Add PostgreSqlStorageDeleteOnClearTests for low-level storage tests - Add PersistenceGrainTests_SqlServer_DeleteStateOnClear for grain-level tests - Add PersistenceGrainTests_Postgres_DeleteStateOnClear for grain-level tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add delete-on-clear support for MySQL and Oracle Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Reuben Bond <reuben.bond@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for issue #8059
Scripts are updated for Mssql and Potgresql only. Mysql and Oracle scripts need to be updated with a new step in OrleansQuery table with QueryKey = 'DeleteStorageKey'. Even so, current implementation should run as is, if DeleteStateOnClear option is not explicitly set to true.
There are some behaviour differences between DeleteStateOnClear option is set to false (same as current functionality and default option for this PR) and true. These are observed with both Postgresql and Mssql providers
Update on clear state =>
If grain whose state is cleared is reinitiated (or application restart), State.RecordExists is seen as true from grain
Delete on ClearState =>
If grain whose state is cleared is reinitiated (or application restart), State.RecordExists is seen as false from grain
Microsoft Reviewers: Open in CodeFlow