Repository navigation
fix(ci): reduce hang dump size - #11405
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Both launch paths apply the narrow diagnostic change consistently, with matching contract coverage and no blocking issues identified.
Review effort: Balanced
Findings: None
What changed in this PR
Reduces CI hang-dump size to help preserve hosted-runner availability and diagnostics.
Changes:
- Uses Heap hang dumps for ordinary and coverage test runs.
- Adds contract checks preserving hang diagnostics, the 10-minute timeout, and Full crash dumps.
| File | Description |
|---|---|
.github/scripts/test-summarize-coverage.ps1 |
Adds dump-configuration contract checks. |
.github/actions/dotnet-test/action.yml |
Switches both hang-dump paths to Heap. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three unrelated CI partitions have stalled beyond the 10-minute inactivity threshold and then lost their hosted runner before the test step, cleanup, logs, or artifacts could complete:
Each test launch requested a Full hang dump. Full dumps include all process memory and mapped module images. On hosted runners, generating that diagnostic for an Orleans test host and its workload can amplify a stall into resource exhaustion, taking down the agent before diagnostics are uploaded.
Solution
Use Heap hang dumps for both ordinary and coverage test paths. Heap dumps retain modules, threads, stacks, handles, and managed memory needed to diagnose a stalled Orleans process while excluding mapped images. Keep Full crash dumps for actual process termination, where complete postmortem state remains the existing diagnostic policy.
Add workflow contract coverage which preserves hang-dump enablement, the 10-minute inactivity threshold, Heap capture on both launch paths, and Full crash diagnostics.
Rationale
This reduces hang-dump size without skipping tests, changing provider coverage, retrying hangs, or converting failures into success. A stalled partition still fails and retains managed state for analysis. The mitigation reduces one shared resource-pressure amplifier; #11331 remains open to correlate recurrence and obtain durable host-level evidence.
Mitigates #11331