Skip to content

build(docs): remove stale NuGet package exceptions - #11401

Merged
ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:rb-nuget-link-allowlist
Oct 3, 2026
Merged

ReubenBond merged 1 commit into
dotnet:mainfrom
ReubenBond:rb-nuget-link-allowlist

Conversation

@ReubenBond

@ReubenBond ReubenBond commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

The documentation link audit fails because the NuGet pages for Microsoft.Orleans.Clustering.TestKit and Microsoft.Orleans.Journaling.S3 now return HTTP 200, making their unpublished-package exceptions stale.

Remove both external-link allowlist entries and their corresponding unpublished API-package entries so generated API pages link to the published packages. Preserve the auditor's stale-entry enforcement.

Fixes #11395.

Microsoft Reviewers: Open in CodeFlow

Copilot AI balanced review requested due to automatic review settings October 3, 2026 14:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused changes match the issue requirements and preserve stale-entry auditing behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Removes obsolete exceptions now that both Orleans packages are published on NuGet.

Changes:

  • Enables generated API links for both published packages.
  • Removes their stale external-link audit allowlist entries.
File Description
docs/​site/​src/​data/​unpublished-api-packages.json Removes both packages from the unpublished list.
docs/​site/​src/​data/​external-link-allowlist.json Removes obsolete NuGet URL exceptions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ReubenBond
ReubenBond force-pushed the rb-nuget-link-allowlist branch from b939c13 to 3bcfece Compare October 3, 2026 14:38
@ReubenBond
ReubenBond merged commit 4a7e8a3 into dotnet:main Oct 3, 2026
81 checks passed
@ReubenBond
ReubenBond deleted the rb-nuget-link-allowlist branch October 3, 2026 14:51
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Code coverage

Metric Pull request
Lines 82.99% (115,626 / 139,318)
Branches 72.38% (33,636 / 46,469)

Report-only conclusion: current-main baseline stale.

The newest successful coverage run tested 6a434ec, not current main 44b9905.

Coverage combines every CI test matrix job, including providers, CodeGen, .NET 8/10, Linux, Windows, and macOS, using canonical physical source and branch identities.

The comparison remains report-only while normal line and branch variance is calibrated.

Coverage details

ReubenBond added a commit to ReubenBond/orleans that referenced this pull request Oct 22, 2026
(cherry picked from commit 4a7e8a3)

Upstream-PR: dotnet#11401
Upstream-Commit: 4a7e8a3
ReubenBond added a commit to ReubenBond/orleans that referenced this pull request Oct 22, 2026
(cherry picked from commit 4a7e8a3)

Upstream-PR: dotnet#11401
Upstream-Commit: 4a7e8a3
ReubenBond added a commit to ReubenBond/orleans that referenced this pull request Oct 23, 2026
(cherry picked from commit 4a7e8a3)

Upstream-PR: dotnet#11401
Upstream-Commit: 4a7e8a3
ReubenBond added a commit that referenced this pull request Oct 23, 2026
(cherry picked from commit 4a7e8a3)

Upstream-PR: #11401
Upstream-Commit: 4a7e8a3
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build(docs): remove stale NuGet allowlist entries for newly published packages

2 participants