You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(docs): serialize Windows Astro output - #11357
Astro prerenders documentation routes concurrently. On Windows, concurrent routes can share output directories and intermittently fail between directory creation and file publication with ENOENT. Node 24.19 can then terminate with a secondary libuv shutdown assertion while handling the build failure.
The race became observable after the Astro documentation site was introduced and the Markdown companion integration expanded the prerender route set.
The first PR run also confirmed that Twitter serves the public Orleans follow intent to browsers but rejects the documentation link audit's bounded automated probe with HTTP 403.
Solution
default Astro route generation to one writer on Windows and retain four workers on other platforms
preserve an explicit ORLEANS_DOCS_BUILD_CONCURRENCY override and reject invalid values
let Linux documentation CI exercise the platform default instead of duplicating it in workflow configuration
document the Windows behavior and the Node 24.20 requirement when opting back into concurrent generation
add the exact Twitter follow intent to the reasoned external-link allowlist
Rationale
Serializing only the affected platform establishes a single-writer filesystem invariant without slowing Linux CI. The override remains available for controlled validation as Astro and Node evolve. The exact allowlist entry preserves the useful browser link while keeping all other external targets actively probed.
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🔵 Needs a closer look
The change targets an intermittent Windows build failure, but the available validation does not establish that the full build succeeds on Windows.
Review effort: Balanced Findings: None
What changed in this PR
This PR aims to prevent intermittent Windows documentation-build failures by serializing Astro route generation there while retaining concurrent generation elsewhere.
Changes:
Adds platform defaults, an override, and tests for build concurrency.
Removes the redundant Linux CI override and documents the Windows behavior.
The newest successful coverage run tested 6bf11ad, not current main 5bebd17.
Coverage combines every CI test matrix job, including providers, CodeGen, .NET 8/10, Linux, Windows, and macOS, using canonical physical source and branch identities.
The comparison remains report-only while normal line and branch variance is calibrated.
The PR description says Fixes #11360, but #11360 is about Consul CI failing to pull an ECR image. This Astro change does not fix that issue, and the closing keyword would close it on merge. Please remove Fixes #11360 from the PR description; keep Closes #10672 for the docs build race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Astro prerenders documentation routes concurrently. On Windows, concurrent routes can share output directories and intermittently fail between directory creation and file publication with
ENOENT. Node 24.19 can then terminate with a secondary libuv shutdown assertion while handling the build failure.The race became observable after the Astro documentation site was introduced and the Markdown companion integration expanded the prerender route set.
The first PR run also confirmed that Twitter serves the public Orleans follow intent to browsers but rejects the documentation link audit's bounded automated probe with HTTP 403.
Solution
ORLEANS_DOCS_BUILD_CONCURRENCYoverride and reject invalid valuesRationale
Serializing only the affected platform establishes a single-writer filesystem invariant without slowing Linux CI. The override remains available for controlled validation as Astro and Node evolve. The exact allowlist entry preserves the useful browser link while keeping all other external targets actively probed.
Closes #10672
Microsoft Reviewers: Open in CodeFlow