Repository navigation
fix(durable-jobs): unregister running shards during shutdown - #11301
Merged
ReubenBond merged 1 commit intoSep 17, 2026
Merged
Conversation
Contributor
Code coverage
Report-only conclusion: current-main baseline stale. The newest successful coverage run tested 3604a08, not current main 2e40fa8. Coverage combines every CI test matrix job, including providers, CodeGen, .NET 8/10, Linux, Windows, and macOS, using canonical physical source and branch identities. The comparison remains report-only while normal line and branch variance is calibrated. Coverage details |
This was referenced Oct 3, 2026
Closed
This was referenced Oct 11, 2026
This was referenced Oct 13, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11273.
Canceled shard runners previously skipped unregistration, removed themselves from the local cache, and disposed their journals before
Stopcould release ownership. Normal unregistration also used the execution token, so shutdown could cancel an ownership update already in progress.Keep unregistration with each runner after normal completion or expected execution cancellation. A separate cleanup token follows the shutdown deadline, allowing ownership release and empty-journal deletion to finish after execution stops. Existing error logging and final disposal remain in place, including for storage failures and independent cancellation.
Add deterministic regressions using real journal storage, fake time, and phase barriers for adopted future shards, queue-change waits, populated ownership release, empty-journal deletion, concurrent normal unregistration, shutdown deadlines, and cleanup failures. Document the graceful-shutdown cleanup boundary for provider retirement.
Microsoft Reviewers: Open in CodeFlow