Skip to content

fix(reminders): recover exact-due persisted reminders - #10430

Merged
ReubenBond merged 4 commits into
dotnet:mainfrom
ReubenBond:reubenbond-fix-reminder-recovery-tick
Aug 11, 2026
Merged

ReubenBond merged 4 commits into
dotnet:mainfrom
ReubenBond:reubenbond-fix-reminder-recovery-tick

Conversation

@ReubenBond

@ReubenBond ReubenBond commented Aug 10, 2026 •

Copy link
Copy Markdown
Member

Fixes #10415.

Reminder reconciliation excluded occurrences due exactly when a table read completed. That avoided duplicate delivery after post-tick eviction, but it could defer an exact-due recovered reminder by a full period.

Load exact-due persisted occurrences and preserve duplicate-delivery protection by recording the fired occurrence in its tombstone. Deterministic boundary tests cover exact-due recovery, same-timestamp refresh after delivery, and long-period cadence behavior. The reminder test-clock infrastructure is also moved under test since it is test-only.

Microsoft Reviewers: Open in CodeFlow

@ReubenBond
ReubenBond force-pushed the reubenbond-fix-reminder-recovery-tick branch from cfe4cfd to e8d0c7c Compare August 10, 2026 23:42
ReubenBond and others added 4 commits August 10, 2026 16:43
Wait for the recovered reminder schedule to be armed, then advance fake time exactly to the persisted cadence boundary. Add boundary arithmetic coverage so deterministic tests cannot overrun delivery by one refresh step.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Load due-now table entries when there is no local reminder state so storage recovery does not drop a scheduled occurrence. Continue suppressing due-now tombstones which prove that the local owner already fired the occurrence.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Relocate the non-packable Orleans.Testing.Reminders project under test, adopt test target-framework defaults, and update the solution and consumer reference.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Track the scheduled occurrence consumed before outside-window eviction so an exact-timestamp refresh cannot redeliver it. Registration tombstones remain eligible for exact-due recovery, and deterministic tests cover both boundaries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ReubenBond
ReubenBond force-pushed the reubenbond-fix-reminder-recovery-tick branch from e8d0c7c to 0ebb1b5 Compare August 10, 2026 23:47
@ReubenBond
ReubenBond merged commit 1d44209 into dotnet:main Aug 11, 2026
72 checks passed
@ReubenBond
ReubenBond deleted the reubenbond-fix-reminder-recovery-tick branch August 11, 2026 00:46
This was referenced Aug 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: Rem_Grain_DistantReminder_DeliveredLateAfterStorageOutageRecovers is one tick late

1 participant