Repository navigation
fix(reminders): recover exact-due persisted reminders - #10430
Merged
ReubenBond merged 4 commits intoAug 11, 2026
Merged
Conversation
ReubenBond
force-pushed
the
reubenbond-fix-reminder-recovery-tick
branch
from
August 10, 2026 23:42
cfe4cfd to
e8d0c7c
Compare
Wait for the recovered reminder schedule to be armed, then advance fake time exactly to the persisted cadence boundary. Add boundary arithmetic coverage so deterministic tests cannot overrun delivery by one refresh step. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Load due-now table entries when there is no local reminder state so storage recovery does not drop a scheduled occurrence. Continue suppressing due-now tombstones which prove that the local owner already fired the occurrence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Relocate the non-packable Orleans.Testing.Reminders project under test, adopt test target-framework defaults, and update the solution and consumer reference. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Track the scheduled occurrence consumed before outside-window eviction so an exact-timestamp refresh cannot redeliver it. Registration tombstones remain eligible for exact-due recovery, and deterministic tests cover both boundaries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
reubenbond-fix-reminder-recovery-tick
branch
from
August 10, 2026 23:47
e8d0c7c to
0ebb1b5
Compare
This was referenced Aug 28, 2026
Merged
Merged
This was referenced Sep 4, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10415.
Reminder reconciliation excluded occurrences due exactly when a table read completed. That avoided duplicate delivery after post-tick eviction, but it could defer an exact-due recovered reminder by a full period.
Load exact-due persisted occurrences and preserve duplicate-delivery protection by recording the fired occurrence in its tombstone. Deterministic boundary tests cover exact-due recovery, same-timestamp refresh after delivery, and long-period cadence behavior. The reminder test-clock infrastructure is also moved under
testsince it is test-only.Microsoft Reviewers: Open in CodeFlow