Repository navigation
fix: fence silos missing from newer membership views - #10262
Merged
ReubenBond merged 5 commits intoJul 15, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af0ee236-db6e-4527-a33e-1dc1a7ff9307
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens Orleans silo self-fencing in the membership subsystem by terminating a silo which has already joined when it observes a strictly newer authoritative membership view that omits its own membership entry (addressing a race where dead-row cleanup can otherwise allow the silo to keep running while heartbeats retry indefinitely).
Changes:
- Extend
MembershipTableManagerupdate processing to fence the local silo when its entry is missing from a strictly newer membership view, while preserving explicit “local entry is Dead” fencing behavior. - Route both table-driven refresh updates and gossip snapshots through a shared membership-update processing path.
- Add regression tests covering explicit-dead snapshots, missing-local-entry behavior across versions, unpublished-join views, and the dead-row cleanup/prune race.
Show a summary per file
| File | Description |
|---|---|
src/Orleans.Runtime/MembershipService/MembershipTableManager.cs |
Adds unified membership-update processing which can self-fence on missing-local-entry in newer views and preserves explicit Dead handling. |
test/Orleans.Core.Tests/Membership/MembershipTableManagerTests.cs |
Adds regression coverage for the new self-fencing scenarios and introduces small helpers for snapshot/manager setup. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af0ee236-db6e-4527-a33e-1dc1a7ff9307
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af0ee236-db6e-4527-a33e-1dc1a7ff9307
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af0ee236-db6e-4527-a33e-1dc1a7ff9307
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: af0ee236-db6e-4527-a33e-1dc1a7ff9307
This was referenced Jul 22, 2026
This was referenced Jul 29, 2026
This was referenced Jul 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Membership self-fencing currently depends on the local Dead tombstone remaining in the membership table. If cleanup removes that row before the silo refreshes, it can continue running while heartbeat updates retry indefinitely.
This change fences an already-joined silo when a strictly newer authoritative membership view omits its local entry. It preserves explicit Dead handling and ignores missing entries in startup, stale, equal, or unpublished-join views. Regression coverage includes the dead-row cleanup race.
Microsoft Reviewers: Open in CodeFlow