Skip to content

DynamoDBStorageOptions ServiceId default #9971

Closed

Description

@cliedeman

Dynamodb Grain Storage ServiceId does not default to default as expected.

https://github.com/dotnet/orleans/blob/v10.0.1/src/AWS/Orleans.Persistence.DynamoDB/Options/DynamoDBStorageOptions.cs#L13

This will be covered up if you the cofiguration (aspire style) but can cause unexpected behaviour otherwise

Activity

  1. ReubenBond commented on Mar 24, 2026

    @ReubenBond
    Member

    Well, that's unfortunate. Thanks for reporting, @cliedeman! I'm wary of changing this now, but perhaps we can add a validation to force people to set it explicitly in an upcoming release. What do you think, @cliedeman?

  2. cliedeman commented on Mar 24, 2026

    @cliedeman
    Author

    I think thats reasonable.

    Luckily I caught this before release but it wasn't obvious to me that my grain keys all being prefixed with an underscore was a bug.

    Ciaran

  3. Laurianti commented on Sep 26, 2026

    @Laurianti
    Contributor

    Following up on the validation idea: rather than failing on an empty ServiceId right away, here is a two-step proposal, both as drafts.

    Tested against DynamoDB Local, across upgrades as-is → #11352 → #11353 and as-is → #11353, for each choice: keep the empty ServiceId, migrate, stop a migration halfway, switch without migrating, a new table, and an explicit ServiceId. The unit tests cover the same cases.

    Happy to rework the design however you prefer, including going back to the plain validation.

  4. Laurianti commented on Oct 21, 2026

    @Laurianti
    Contributor

    @ReubenBond, as you suggested, #11551 adds the validation: a silo with DynamoDB grain storage doesn't start until ServiceId is set, and an empty string keeps the existing keys.

    #11352 and #11353 took a fuller approach, switching to ClusterOptions.ServiceId and migrating the existing keys. I've closed them so there is one PR to review, and can reopen them if you'd like that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions