You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Well, that's unfortunate. Thanks for reporting, @cliedeman! I'm wary of changing this now, but perhaps we can add a validation to force people to set it explicitly in an upcoming release. What do you think, @cliedeman?
Tested against DynamoDB Local, across upgrades as-is → #11352 → #11353 and as-is → #11353, for each choice: keep the empty ServiceId, migrate, stop a migration halfway, switch without migrating, a new table, and an explicit ServiceId. The unit tests cover the same cases.
Happy to rework the design however you prefer, including going back to the plain validation.
@ReubenBond, as you suggested, #11551 adds the validation: a silo with DynamoDB grain storage doesn't start until ServiceId is set, and an empty string keeps the existing keys.
#11352 and #11353 took a fuller approach, switching to ClusterOptions.ServiceId and migrating the existing keys. I've closed them so there is one PR to review, and can reopen them if you'd like that later.
Activity
ReubenBond commentedon Mar 24, 2026
Well, that's unfortunate. Thanks for reporting, @cliedeman! I'm wary of changing this now, but perhaps we can add a validation to force people to set it explicitly in an upcoming release. What do you think, @cliedeman?
cliedeman commentedon Mar 24, 2026
I think thats reasonable.
Luckily I caught this before release but it wasn't obvious to me that my grain keys all being prefixed with an underscore was a bug.
Ciaran
Laurianti commentedon Sep 26, 2026
Following up on the validation idea: rather than failing on an empty
ServiceIdright away, here is a two-step proposal, both as drafts.UseClusterServiceIdandMigrateLegacyKeys, both unset by default, so nothing changes until they are set, apart from a startup warning. The migration moves each grain on its next write, in one transaction. The choice is recorded in the table.ClusterOptions.ServiceIdthe default, and refuses to start when the table holds state under the underscore keys and neither option says what to do with it.Tested against DynamoDB Local, across upgrades as-is → #11352 → #11353 and as-is → #11353, for each choice: keep the empty
ServiceId, migrate, stop a migration halfway, switch without migrating, a new table, and an explicitServiceId. The unit tests cover the same cases.Happy to rework the design however you prefer, including going back to the plain validation.
Laurianti commentedon Oct 21, 2026
@ReubenBond, as you suggested, #11551 adds the validation: a silo with DynamoDB grain storage doesn't start until
ServiceIdis set, and an empty string keeps the existing keys.#11352 and #11353 took a fuller approach, switching to
ClusterOptions.ServiceIdand migrating the existing keys. I've closed them so there is one PR to review, and can reopen them if you'd like that later.