Skip to content

Consolidate shared files into owning assemblies - #15431

Merged
JanProvaznik merged 25 commits into
mainfrom
dustinca/unshare-files
Nov 4, 2026
Merged

JanProvaznik merged 25 commits into
mainfrom
dustinca/unshare-files

Conversation

@DustinCampbell

Copy link
Copy Markdown
Member

I'm sure everyone has wanted this for a long time. Following this change, only ErrorUtilities.cs and ResourceUtilities.cs are still linked into production assemblies because they're more involved to deal with.

Tip

It's a big change, but the commit history is well-organized. Review commit-by-commit if the sheer number of files is daunting.

Context

Much of MSBuild's internal infrastructure is compiled from linked source into multiple assemblies.
This duplicates implementations and creates distinct type identities for code that should have a
single owner. This refactor replaces unnecessary source sharing with explicit assembly ownership
while retaining sharing where assembly-local resource lookup or test setup requires it.

Changes Made

  • Centralize task logging, task and type loading, debugging, node and task-host protocol
    infrastructure, registered task-object caching, shared helpers, and file-tracker interop in
    Microsoft.Build.Framework.
  • Move engine shutdown state, task assembly resolution, and tracing into Microsoft.Build; move RAR
    pipe infrastructure and language parsing into Microsoft.Build.Tasks.
  • Move task-host configuration and completion contracts into Framework. Transfer remote host-object
    registrations through an internal wire contract while keeping HostServices in Build.
  • Move the six public file-access types into Framework and add type forwarders for those types and
    the relocated task-logging APIs.
  • Align tests with implementation ownership, add forwarding and serialization coverage, and fix
    boxed file-access struct deserialization.
  • Remove obsolete shared files and source links, and document the remaining source-sharing rules.

Compatibility

Public task-logging and file-access APIs retain their namespaces and remain accessible through type
forwarders. Node and task-host packet IDs, field order, presence markers, and version gates are
preserved, including compatibility with older hosts.

HostServices remains in Microsoft.Build. Its remote-registration reconstruction preserves legacy
lookup behavior without introducing a Framework dependency on Build, Tasks, or Utilities.
MSBuildTaskHost's independent implementation is unchanged.

AppDomain-lifetime registered-task-object storage is shared across consumers in the same AppDomain;
build-lifetime storage remains per cache instance. The refactor introduces no new diagnostics or
configuration defaults.

Testing

  • .\build.cmd -test — passed on the latest branch revision, including the full repository build
    and test run.
  • Added coverage for public type forwarding, resource lookup, legacy host-services payload
    compatibility, packet-version gates, null and empty registrations, host-services isolation, and
    populated file-access round trips.

Move TaskLoggingHelper, TaskLoggingHelperExtension, and CanonicalError
into Microsoft.Build.Framework instead of compiling shared copies.

Preserve public type identities with Utilities and Tasks forwarders
and update engine consumers to use the consolidated helpers.

Move logging and parser tests to Framework.UnitTests and add resource
lookup, exception behavior, and type-forwarding coverage.
Move TaskParameter, TaskParameterTypeVerifier, and
TaskParameterValueStringConverter into Microsoft.Build.Framework.
Remove their shared source links from Build, MSBuild, and Tasks.

Move TaskParameter_Tests into Build.UnitTests, preserving existing
serialization and AppDomain coverage.
Move RegisteredTaskObjectCacheBase into Framework and remove the
separate source inclusions from Build and MSBuild. Use a single
namespace for both consumers.

Unify AppDomain-lifetime storage so engine and task-host consumers
in the same AppDomain share registered objects, as intended.
Build-lifetime storage remains per cache instance.
Move PropertyParser into Framework under Microsoft.Build.Utilities
and remove the shared source links from Build and Tasks. Update
ProjectInterpretation to import the canonical namespace.

Move PropertyParser_Tests from Tasks.UnitTests to Framework.UnitTests.
Preserve existing parsing, escaping, and diagnostic behavior.
Move PlatformNegotiation into Framework and remove the shared source
links from Build and Tasks. Preserve the existing namespace, platform
selection precedence, lookup-table parsing, and diagnostics.

Retain task and graph tests in their existing projects, exercising
the shared Framework implementation through each consumer.
Move NodePipeBase, NodePipeClient, and NodePipeServer from Shared
into Tasks under AssemblyDependency\Node. Update the Tasks project
to compile the files from their owning directory.

Preserve existing namespaces, assembly identity, and pipe behavior.
Move all eleven LanguageParser source files from Shared into Tasks
and update the explicit compile includes to use their new paths.

Preserve file contents, namespaces, and assembly identity. Existing
tokenizer, stream, and parser-utility tests remain in Tasks.UnitTests.
Move NodeEngineShutdownReason from Shared into Build under
BackEnd\Node and update the explicit compile include.

Preserve the public namespace, assembly identity, and enum values.
Use a file-scoped namespace and remove the redundant region.
Move TaskEngineAssemblyResolver from Shared into Build under
BackEnd\TaskExecutionHost. Change its namespace to Microsoft.Build.BackEnd
and remove the obsolete TaskRegistry alias.

Update the Build compile include and remove the unused CLI source link.
Preserve existing assembly resolution and handler lifecycle behavior.
Move node endpoint and packet interfaces, NodePacketFactory,
LogMessagePacketBase, NodeBuildComplete, and NodeShutdown from Shared
into Framework. Remove their source links from Build, MSBuild, and Tasks.

Extract LinkStatus, LoggingEventType, NodeBuildCompleteAction, and
NodeShutdownReason into separate files. Use file-scoped namespaces
and remove redundant regions.

Preserve namespaces, enum values, packet layout, version negotiation,
and logging serialization behavior.
Move VisualStudioConstants from Shared into Framework and remove
the Build and Tasks source links.

Preserve the existing namespace, accessibility, and constant values.
Use a file-scoped namespace.
Move the shared debugging helpers into Framework and merge
FrameworkDebugUtils into DebugUtils. Update all consumers and remove
DebuggingSources.proj and its imports.

Preserve startup-safe initialization and defer dump-path fallback
resolution. Store the shared writer directly on PrintLineDebugger
and remove the CommonWriter holder.

Move DebugUtils and PrintLineDebugger tests into Framework.UnitTests
and remove the redundant test source links.
Move TaskLoader from Shared into Framework under Loader and remove
the Build and CLI source links. Use a file-scoped namespace while
preserving the existing type namespace.

Preserve task construction, AppDomain configuration, assembly resolver
cleanup, and caller-owned diagnostic logging.
Move TypeLoader into Framework and remove the Build and CLI source
links. Move the MetadataLoadContext package reference to Framework,
preserving loader behavior and trimming annotations.

Move both type-loader test suites from Shared into Build.UnitTests
and remove their explicit source links.
Move NodeEndpointOutOfProcBase into Framework and remove the Build
and CLI source links. Preserve pipe connection, handshake, packet
negotiation, and read/write behavior.

Adopt a file-scoped namespace, remove regions, and make the Tasks
namespace import unconditional for netstandard2.0 compilation.
Move the task-host callback interface, request/response packets,
cancellation packet, and invariant payload transfer mode into
Framework. Remove their Build and CLI source links.

Preserve packet IDs, serialization order, version gates, and enum
values. Adopt file-scoped namespaces in the relocated files.
Move InprocTrackingNativeMethods into Framework under the
Microsoft.Build.Framework namespace. Remove the Build and Utilities
source links and update FullTracking's import.

Preserve native DLL resolution, export signatures, HRESULT handling,
and FEATURE_FILE_TRACKER conditioning. Adopt a file-scoped namespace.
Move MSBuild boolean string helpers into Framework's Utilities
namespace and update the BuildCheck imports. Remove the Build, CLI,
and Utilities test source links.

Consolidate compatibility methods into the string, span, builder,
and text-writer polyfill classes, guarded by !NET. Use
StringBuilderCache in the Replace polyfill while preserving its
capacity calculation and no-match fast path.

Move replacement tests into Framework.UnitTests and restrict them
to targets that use the polyfill.
Merge the shared native-method tests into Framework.UnitTests and
remove their Tasks and Utilities source links. Both previously
tested the same Framework implementation.

Preserve file-system, native-export, and console-override coverage.
Use Shouldly assertions and TestEnvironment cleanup, and guard the
Windows export test when Windows interop is unavailable.
Move AssemblyNameEx and XMakeAttributes tests into Framework.UnitTests,
removing their source links from Build.UnitTests and Tasks.UnitTests.

Use Shouldly throughout, convert focused cases to theories, simplify
assertions, and clean up test names and XML documentation.
Copilot AI balanced review requested due to automatic review settings October 31, 2026 00:54
@DustinCampbell

Copy link
Copy Markdown
Member Author

I ran the expert code review locally before submitting this PR and it gave me a thumbs up. We'll see how this goes...

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Public API relocation and loader/cache consolidation require maintainer review of binary compatibility with precompiled tasks and mixed-version .NET Framework/AppDomain hosts, which the reviewed source and forwarding tests cannot establish.

No open issues 🎉

What changed in this PR

This PR replaces duplicated, source-linked MSBuild infrastructure with explicit assembly ownership. Shared functionality moves primarily into Framework, while engine-specific and task-specific code stays with Build and Tasks; public API compatibility is maintained through type forwarders.

Changes:

  • Consolidates helpers, debugging, task-host contracts, and file-access types into their owning assemblies.
  • Introduces a remote host-registration payload while keeping HostServices in Build.
  • Updates consumers, relocates tests, adds compatibility coverage, and documents the remaining source-sharing rules.
File Description
src/​Utilities/​Microsoft.Build.Utilities.csproj Removes links to consolidated implementations.
src/​Utilities/​AssemblyInfo.cs Forwards TaskLoggingHelper to Framework.
src/​Utilities.UnitTests/​TypeForwarders_Tests.cs Adds logging-helper forwarding coverage.
src/​Utilities.UnitTests/​StringExtensions_Tests.cs Removes tests relocated to Framework.
src/​Utilities.UnitTests/​Microsoft.Build.Utilities.UnitTests.csproj Removes obsolete shared source links.
src/​UnitTests.Shared/​TestEnvironment.cs Uses consolidated debug-path helpers.
src/​UnitTests.Shared/​Microsoft.Build.UnitTests.Shared.csproj Removes the shared IsExternalInit link.
src/​Tasks/​Microsoft.Build.Tasks.csproj Replaces shared links with owned parser and pipe sources.
src/​Tasks/​LanguageParser/​VisualBasicTokenizer.cs Relocates the Visual Basic tokenizer into Tasks.
src/​Tasks/​LanguageParser/​TokenEnumerator.cs Relocates the base token enumerator into Tasks.
src/​Tasks/​LanguageParser/​Token.cs Relocates language token definitions into Tasks.
src/​Tasks/​LanguageParser/​CSharptokenizer.cs Relocates the C# tokenizer into Tasks.
src/​Tasks/​LanguageParser/​CSharpTokenCharReader.cs Relocates C# character parsing into Tasks.
src/​Tasks/​AssemblyInfo.cs Forwards TaskLoggingHelperExtension to Framework.
src/​Tasks/​AssemblyDependency/​Node/​NodePipeClient.cs Relocates the RAR pipe client into Tasks.
src/​Tasks.UnitTests/​TypeForwarders_Tests.cs Verifies logging-extension forwarding.
src/​Tasks.UnitTests/​Microsoft.Build.Tasks.UnitTests.csproj Removes redundant shared test links.
src/​Shared/​VisualStudioConstants.cs Removes constants relocated to Framework.
src/​Shared/​UnitTests/​TestAssemblyInfo.cs Refreshes the consolidated debug-path cache.
src/​Shared/​UnitTests/​NativeMethodsShared_Tests.cs Removes the source-shared native-helper test file.
src/​Shared/​UnitTests/​AssemblyResources.cs Removes the dummy test resource helper.
src/​Shared/​Tracing.cs Removes tracing from source sharing.
src/​Shared/​TaskLoggingHelperExtension.cs Removes the source-shared logging extension.
src/​Shared/​TaskHostTaskCancelled.cs Removes the relocated cancellation packet.
src/​Shared/​TaskHostIsRunningMultipleNodesResponse.cs Removes the relocated node-count response.
src/​Shared/​TaskHostIsRunningMultipleNodesRequest.cs Removes the relocated node-count request.
src/​Shared/​TaskHostCoresResponse.cs Removes the relocated core-allocation response.
src/​Shared/​TaskHostCoresRequest.cs Removes the relocated core-allocation request.
src/​Shared/​TaskHostBuildResponse.cs Removes the source-shared build-response packet.
src/​Shared/​StringExtensions.cs Removes helpers consolidated into Framework.
src/​Shared/​SharedCode.md Documents ownership and retained sharing rules.
src/​Shared/​README.txt Updates the directory description and documentation pointer.
src/​Shared/​OutOfProcTaskHostTaskResult.cs Removes the source-shared task-result contract.
src/​Shared/​NodeShutdown.cs Removes the relocated shutdown packet.
src/​Shared/​NodePacketFactory.cs Removes the relocated packet factory.
src/​Shared/​NodeEngineShutdownReason.cs Removes the enum relocated to Build.
src/​Shared/​NodeBuildComplete.cs Removes the relocated build-completion packet.
src/​Shared/​NamedPipeUtil.cs Removes the source-shared pipe-naming helper.
src/​Shared/​ITaskHostCallbackPacket.cs Removes the relocated callback contract.
src/​Shared/​IsExternalInit.cs Removes the shared initialization polyfill.
src/​Shared/​InvariantPayloadTransferMode.cs Removes the relocated transfer-mode enum.
src/​Shared/​INodePacketHandler.cs Removes the relocated packet-handler interface.
src/​Shared/​INodePacketFactory.cs Removes the relocated packet-factory interface.
src/​Shared/​INodeEndpoint.cs Removes the relocated endpoint contracts.
src/​Shared/​DebuggingSources.proj Removes the shared debugging-source import.
src/​Shared/​Debugging/​PrintLineDebuggerWriters.cs Removes writers relocated to Framework.
src/​Shared/​Debugging/​PrintLineDebugger.cs Removes the source-shared print-line debugger.
src/​MSBuild/​XMake.cs Uses consolidated debugging and process-mode helpers.
src/​MSBuild/​OutOfProcTaskHostNode.cs Updates imports for relocated infrastructure.
src/​MSBuild/​OutOfProcTaskAppDomainWrapperBase.cs Reconstructs host services from registration data.
src/​MSBuild/​MSBuild.csproj Removes links to consolidated infrastructure.
src/​MSBuild.UnitTests/​OutOfProcTaskAppDomainWrapper_Tests.cs Updates payload arguments and tests empty registrations.
src/​MSBuild.Coordinator/​CoordinatorServer.DefaultDebugOutput.cs Uses the consolidated debug-path helper.
src/​MSBuild.Coordinator.UnitTests/​CoordinatorIntegration_Tests.cs Updates debug-path setup and cleanup.
src/​Framework/​VisualStudioConstants.cs Establishes Framework ownership of shared constants.
src/​Framework/​Utilities/​TaskLoggingHelperExtension.cs Owns the public two-resource logging helper.
src/​Framework/​Utilities/​StringExtensions.cs Centralizes MSBuild boolean-string helpers.
src/​Framework/​Utilities/​PropertyParser.cs Uses a single utility namespace.
src/​Framework/​Utilities/​PlatformNegotiation.cs Uses the consolidated logging-helper namespace.
src/​Framework/​Utilities/​CanonicalError.cs Simplifies lazy regex storage.
src/​Framework/​Polyfills/​TextWriterExtensions.cs Centralizes span-based writer polyfills.
src/​Framework/​Polyfills/​StringExtensions.cs Adds the comparison-aware replacement polyfill.
src/​Framework/​Polyfills/​StringBuilderExtensions.cs Centralizes the span append polyfill.
src/​Framework/​Polyfills/​SpanExtensions.cs Adds the common-prefix-length polyfill.
src/​Framework/​Microsoft.Build.Framework.csproj Adds the metadata-loading dependency.
src/​Framework/​FileAccess/​RequestedAccess.cs Relocates the public requested-access enum.
src/​Framework/​FileAccess/​ProcessData.cs Relocates public process data and serialization.
src/​Framework/​FileAccess/​DesiredAccess.cs Relocates the public desired-access enum.
src/​Framework/​DebugUtils.cs Removes the separate FrameworkDebugUtils implementation.
src/​Framework/​Debugging/​PrintLineDebuggerWriters.cs Centralizes print-line output writers.
src/​Framework/​Debugging/​PrintLineDebugger.cs Centralizes the debugger and shared writer state.
src/​Framework/​Debugging/​CommonWriter.cs Removes the redundant writer-state holder.
src/​Framework/​BackEnd/​TaskParameterValueStringConverter.cs Centralizes task-value string conversion.
src/​Framework/​BackEnd/​TaskParameterTypeVerifier.cs Centralizes task-parameter type validation.
src/​Framework/​BackEnd/​TaskParameter.cs Uses Framework resources for metadata validation.
src/​Framework/​BackEnd/​TaskHostTaskCancelled.cs Owns the task cancellation packet.
src/​Framework/​BackEnd/​TaskHostIsRunningMultipleNodesResponse.cs Owns the multiple-node query response.
src/​Framework/​BackEnd/​TaskHostIsRunningMultipleNodesRequest.cs Owns the multiple-node query request.
src/​Framework/​BackEnd/​TaskHostCoresResponse.cs Owns the core-allocation response packet.
src/​Framework/​BackEnd/​TaskHostCoresRequest.cs Owns the core-allocation request packet.
src/​Framework/​BackEnd/​TaskCompleteType.cs Defines shared task-completion states.
src/​Framework/​BackEnd/​RegisteredTaskObjectCacheBase.cs Unifies cache ownership and AppDomain-lifetime storage.
src/​Framework/​BackEnd/​NodeShutdownReason.cs Owns node shutdown reason definitions.
src/​Framework/​BackEnd/​NodeShutdown.cs Owns the node shutdown packet.
src/​Framework/​BackEnd/​NodePacketFactory.cs Centralizes packet construction and routing.
src/​Framework/​BackEnd/​NodeBuildCompleteAction.cs Separates build-completion action definitions.
src/​Framework/​BackEnd/​NodeBuildComplete.cs Owns the version-gated build-completion packet.
src/​Framework/​BackEnd/​LinkStatus.cs Owns endpoint connection-state definitions.
src/​Framework/​BackEnd/​ITaskHostCallbackPacket.cs Centralizes callback request correlation.
src/​Framework/​BackEnd/​IRemoteHostServicesInitializer.cs Adds an internal host-services initialization contract.
src/​Framework/​BackEnd/​InvariantPayloadTransferMode.cs Owns invariant-payload transfer modes.
src/​Framework/​BackEnd/​INodePacketHandler.cs Centralizes the packet-handler contract.
src/​Framework/​BackEnd/​INodePacketFactory.cs Centralizes packet-factory contracts.
src/​Framework/​BackEnd/​INodeEndpoint.cs Centralizes endpoint communication contracts.
src/​Framework/​BackEnd/​HostServicesData.cs Adds remote registration data using the legacy wire layout.
src/​Framework/​BackEnd/​CommunicationsUtilities.cs Uses consolidated debug initialization and paths.
src/​Framework.UnitTests/​TaskLoggingHelperExtension_Tests.cs Tests resource precedence, fallback, and failures.
src/​Framework.UnitTests/​strings.resx Adds a resource-precedence test fixture.
src/​Framework.UnitTests/​StringExtensions_Tests.cs Relocates replacement-polyfill coverage.
src/​Framework.UnitTests/​PropertyParser_Tests.cs Uses the parser’s consolidated namespace.
src/​Framework.UnitTests/​MockTask.cs Implements ITask directly with Framework resources.
src/​Framework.UnitTests/​Microsoft.Build.Framework.UnitTests.csproj Removes the shared resource-helper link.
src/​Framework.UnitTests/​DebugUtils_Tests.cs Targets the consolidated debug utility.
src/​BuildCheck.UnitTests/​Microsoft.Build.BuildCheck.UnitTests.csproj Removes the shared IsExternalInit link.
src/​Build/​Logging/​TerminalLogger/​Terminal.cs Removes an obsolete polyfill namespace import.
src/​Build/​Logging/​BinaryLogger/​ProjectImportsCollector.cs Uses the consolidated utility namespace.
src/​Build/​Instance/​TaskRegistry.cs Removes the old assembly-resolver alias.
src/​Build/​Instance/​TaskFactories/​TaskHostTask.cs Creates configurations with remote registration snapshots.
src/​Build/​Instance/​HostServices.cs Exports and reconstructs remote host registrations.
src/​Build/​Graph/​ProjectInterpretation.cs Imports consolidated utilities.
src/​Build/​Evaluation/​Expander/​WellKnownFunctions.cs Removes an obsolete shared namespace import.
src/​Build/​BuildCheck/​Checks/​TargetFrameworkUnexpectedCheck.cs Imports relocated boolean-string helpers.
src/​Build/​BuildCheck/​Checks/​EmbeddedResourceCheck.cs Imports relocated boolean-string helpers.
src/​Build/​BuildCheck/​Checks/​CopyAlwaysCheck.cs Imports relocated boolean-string helpers.
src/​Build/​BackEnd/​TaskExecutionHost/​TaskExecutionHost.cs Cleans up imports and aliases.
src/​Build/​BackEnd/​TaskExecutionHost/​TaskEngineAssemblyResolver.cs Places the resolver in Build’s backend namespace.
src/​Build/​BackEnd/​Node/​NodeEngineShutdownReason.cs Establishes Build ownership of the public enum.
src/​Build/​BackEnd/​Components/​Scheduler/​Scheduler.cs Uses the consolidated debug-path helper.
src/​Build/​BackEnd/​Components/​RequestBuilder/​RequestBuilder.cs Imports consolidated utilities.
src/​Build/​BackEnd/​Components/​RequestBuilder/​IntrinsicTasks/​MSBuild.cs Uses consolidated logging APIs and lazy storage.
src/​Build/​BackEnd/​Components/​RequestBuilder/​IntrinsicTasks/​CallTarget.cs Uses the consolidated logging helper.
src/​Build/​BackEnd/​Components/​RequestBuilder/​FullTracking.cs Updates the import for Framework-owned tracking infrastructure.
src/​Build/​BackEnd/​Components/​BuildRequestEngine/​BuildRequestEngine.cs Uses the consolidated debug-path helper.
src/​Build/​BackEnd/​BuildManager/​BuildManager.cs Uses consolidated process-debugging state.
src/​Build/​AssemblyInfo.cs Forwards six public file-access types to Framework.
src/​Build.UnitTests/​TypeLoader_Dependencies_Tests.cs Places dependency-loading integration tests in Build.
src/​Build.UnitTests/​TypeForwarders_Tests.cs Verifies file-access type forwarding.
src/​Build.UnitTests/​Microsoft.Build.Engine.UnitTests.csproj Removes relocated shared test links.
src/​Build.UnitTests/​BackEnd/​TaskExecutionHost_Tests.cs Updates debug-path refresh calls.
src/​Build.UnitTests/​BackEnd/​NodeEndpointReadLoop_Tests.cs Updates debug-path setup and cleanup.
src/​Build.UnitTests/​BackEnd/​BuildManager_Tests.cs Uses consolidated debugging helpers in scheduler tests.

Review effort: Balanced

Move Tracing into Build's Utilities directory and remove unused source
links from Tasks and Utilities.

Keep tracing state and method bodies behind DEBUG while retaining
conditional declarations for callers. Replace the explicit static
constructor with field initializers, simplify counter updates, and
refresh XML documentation.
Move task-host completion, result, and enum types into Framework and
remove their Build and MSBuild source links.

Move the six public file-access types into Framework, preserving their
namespaces and adding Build type forwarders with compatibility coverage.

Split the completion constructor into common and file-access overloads,
refresh result documentation, and add populated file-access round-trip
coverage.
Move TaskHostConfiguration out of Shared and remove its source links
from Build and MSBuild.

Introduce HostServicesData and IRemoteHostServicesInitializer to
transfer remote registrations while keeping HostServices in Build.
Preserve the legacy wire format, packet-version gates, and lookup
semantics without introducing a Framework dependency on Build.

Split the AppDomain constructor overload, add compatibility and
isolation coverage, and convert configuration assertions to Shouldly.
Delete the orphaned pipe helper and test resource stub. Remove the
redundant IsExternalInit polyfill and its test-project source links.

Remove Framework.UnitTests' unused ResourceUtilities source link.

Update Shared documentation to explain the retained source-sharing
rules and replace the README's obsolete document reference.

@JanProvaznik JanProvaznik left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

needs

  • VS insertion
  • vmr test run

Comment thread src/Tasks/Microsoft.Build.Tasks.csproj Resolved
@JanProvaznik

Copy link
Copy Markdown
Member

@JanProvaznik

Copy link
Copy Markdown
Member

Unsigned unified VMR validation passed: dotnet-unified-build 20261103.15 (pipeline 1330, desiredSigning=Unsigned).

I overlaid this PR at d154001c56eda62cfa500fe270729f8ef3b2b969 onto internal dotnet-dotnet main 4c72591066848c3106d4f63b7bbead73ce2e0b7a; validation commit: 726b261b3c16b80691cb95f51009f19c35363214.

All seven stages and all jobs succeeded, including Windows/Linux/macOS verticals, mobile/WASM short stacks, source-only builds and validation, installer validation, SDL, and asset publishing. No failed, canceled, or partially successful tasks/jobs were reported. The run completed in 6h 10m; no regressions were detected by this CI run. This result applies to the PR revision above and does not cover signed-build behavior.

@JanProvaznik

Copy link
Copy Markdown
Member

Insertion is ok except that their compat harness does not recognize the forwarders, so will need VS api approve

@JanProvaznik JanProvaznik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

@JanProvaznik
JanProvaznik merged commit 491de60 into main Nov 4, 2026
13 checks passed
@JanProvaznik
JanProvaznik deleted the dustinca/unshare-files branch November 4, 2026 10:16
@DustinCampbell

Copy link
Copy Markdown
Member Author

Insertion is ok except that their compat harness does not recognize the forwarders, so will need VS api approve

Is that true? I looked at the insertion and it seemed that the failed API compat tests were all due to live share, which isn't relevant to this PR.

@JanProvaznik

Copy link
Copy Markdown
Member

liveshare was a separate problem

there were real move issues in e.g. https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=15917793&view=ms.vss-test-web.build-test-results-tab&runId=186845666&resultId=100001&paneView=attachments

lewing added a commit to dotnet/runtime that referenced this pull request Nov 11, 2026
ApiCompat 12.0.100-alpha.1.26561.101 is built against MSBuild that includes
dotnet/msbuild#15431 (TaskLoggingHelper moved to Microsoft.Build.Framework),
but SDK 12.0.100-alpha.1.26555.106 ships an older MSBuild, causing
MissingMethodException for Task.get_Log(). Use the SDK from the same VMR build.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants