Skip to content

Remove Linux Core Multithreaded Mode CI job - #15398

Merged
JanProvaznik merged 2 commits into
dotnet:mainfrom
JanProvaznik:chore/remove-mt-analyzer-ci-job
Oct 26, 2026
Merged

JanProvaznik merged 2 commits into
dotnet:mainfrom
JanProvaznik:chore/remove-mt-analyzer-ci-job

Conversation

@JanProvaznik

Copy link
Copy Markdown
Member

Related issue(s):

Context

The Linux Core Multithreaded Mode job (BootstrapMSBuildWithMTMode) no longer earns its place in PR CI:

  • It was added to validate -mt, which every bootstrapped PR job now runs through Directory.Build.rsp (Revert "Revert "Add multi-threading option to build response file"" #14855) and Enable -mt in PR CIs with 2 stages #13678.
  • Its only remaining difference is /p:BuildAnalyzer=true, which runs the TaskAnalyzer over Microsoft.Build.Tasks. The output is informational only: MSBuildTask0002-0008 are in WarningsNotAsErrors, so findings can never fail the job, and TaskAnalyzer.Tests already runs in Linux Core.
  • It floats on ubuntu-latest, unlike the pinned Linux Core job. Since the image moved to Ubuntu 26.04, every run of this job has failed on an apt-get install step (e.g. build 1648793), which turns the required msbuild-pr check red even when Linux Core passes.

Changes Made

Delete the BootstrapMSBuildWithMTMode job from .vsts-dotnet-ci.yml. The BuildAnalyzer property in Microsoft.Build.Tasks.csproj is kept; the TaskAnalyzer README documents running it locally (dotnet build src/Tasks/Microsoft.Build.Tasks.csproj /p:BuildAnalyzer=true).

Compatibility

CI-only change; no product impact. The required checks on main are msbuild-pr and license/cla, not the individual job, so no check is left pending. The analyzer sweep over Microsoft.Build.Tasks is no longer run automatically; if that signal is wanted, it could move to a scheduled pipeline.

Testing

  • Parsed the edited .vsts-dotnet-ci.yml with PyYAML; the remaining jobs (BootstrapMSBuildOnFullFrameworkWindows, BootstrapMSBuildOnCoreWindows, FullReleaseOnWindows, CoreBootstrappedOnLinux, CoreOnMac, CodeCoverage) are intact.
  • No remaining references to the job name or its MTModeOnLinux build logs artifact in the repo.
  • Not run locally: the pipeline itself; this PR's msbuild-pr run is the validation.

Dependencies and Follow-up

Stacked on #15397, which removes the failing apt-get steps from the same job as a minimal unblock. This branch contains that commit; the identical change merges cleanly whichever PR lands first. If #15397 merges alone, this PR is the optional follow-up to delete the job.

JanProvaznik and others added 2 commits October 26, 2026 13:03
ubuntu-latest now resolves to Ubuntu 26.04, which no longer ships a
libxml2 package (it is libxml2-16), so 'apt-get install -y libxml2'
fails with exit code 100 and fails the whole job.

The job runs no tests ("Intentionally not running tests"); libxml2 was
added alongside the code-coverage tooling, which this job does not use.
The build and stage2 build in the failed run completed with 0 errors
without it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e6c0b687-cb7d-4a28-81a2-150c0bd191d5
The job existed to validate /mt, which every bootstrapped PR job now
runs via Directory.Build.rsp (dotnet#14855) and dotnet#13678. Its only remaining
difference is /p:BuildAnalyzer=true, which runs the TaskAnalyzer over
Microsoft.Build.Tasks. That output is informational: MSBuildTask0002-0008
are in WarningsNotAsErrors, so findings cannot fail the job, and
TaskAnalyzer.Tests already runs in Linux Core.

The job floats on ubuntu-latest and has failed on every run since the
image moved to Ubuntu 26.04, turning the required msbuild-pr check red.

/p:BuildAnalyzer=true is kept in Microsoft.Build.Tasks.csproj; the
TaskAnalyzer README documents running it locally.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e6c0b687-cb7d-4a28-81a2-150c0bd191d5

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The deletion is self-contained, preserves multithreaded build coverage, and leaves no unresolved job dependencies or blocking findings.

No open issues 🎉

What changed in this PR

Removes the redundant Linux Core Multithreaded Mode job from PR CI, while retaining multithreaded build coverage in the existing bootstrapped jobs.

Changes:

  • Deletes BootstrapMSBuildWithMTMode, including its setup steps and log artifact publication.
  • Stops the automatic TaskAnalyzer sweep over built-in tasks; local analyzer execution remains available.
File Description
.vsts-dotnet-ci.yml Removes the dedicated Linux multithreaded/analyzer job without changing the remaining jobs.

Review effort: Balanced

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK Integration Boundaries — LGTM

Warning

Firewall blocked 5 domains

The following domains were blocked by the firewall during workflow execution:

  • api.github.com
  • cdn.jsdelivr.net
  • github.com
  • patchdiff.githubusercontent.com
  • raw.githubusercontent.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "cdn.jsdelivr.net"
    - "github.com"
    - "patchdiff.githubusercontent.com"
    - "raw.githubusercontent.com"

See Network Configuration for more information.

Generated by Expert Code Review (on open) for #15398 · copilot · gpt56 · 465.3 AIC · ⌖ 0.52 AIC · ⊞ 19K

@JanProvaznik
JanProvaznik merged commit edf915b into dotnet:main Oct 26, 2026
19 of 20 checks passed

This branch had an error being deployed

1 failed deployment
copilot-pat-pool — 27110b87 Deployed Oct 26, 2026 by JanProvaznik via conclusion #1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants