Skip to content

Revert "Add multi-threading option to build response file" - #14851

Merged
ViktorHofer merged 1 commit into
mainfrom
revert-14837-ViktorHofer-patch-1
Aug 26, 2026
Merged

ViktorHofer merged 1 commit into
mainfrom
revert-14837-ViktorHofer-patch-1

Conversation

@ViktorHofer

@ViktorHofer ViktorHofer commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

Reverts #14837

Some arcade tasks that directly log to the console via the System.Console APIs to set ADO variables aren't compatible with -mt yet.

Copilot AI lite review requested due to automatic review settings August 26, 2026 16:41
@ViktorHofer
ViktorHofer requested a review from a team as a code owner August 26, 2026 16:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the default -mt (multi-threading) setting previously added to the repo’s build response file, because some Arcade tasks that write directly to System.Console (for ADO variable setting) are not compatible with -mt yet.

Changes:

  • Removed /mt from Directory.Build.rsp so repo builds no longer opt into -mt by default.
  • Restored the response file line to a single, clean command-line argument list.
Show a summary per file
File Description
Directory.Build.rsp Removes /mt from default build arguments to restore compatibility with console-logging Arcade tasks.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

@ViktorHofer
ViktorHofer enabled auto-merge (squash) August 26, 2026 16:55
@ViktorHofer
ViktorHofer merged commit 9873fa4 into main Aug 26, 2026
17 of 18 checks passed
@ViktorHofer
ViktorHofer deleted the revert-14837-ViktorHofer-patch-1 branch August 26, 2026 18:21
ViktorHofer added a commit that referenced this pull request Aug 27, 2026
This was referenced Nov 15, 2026

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — 25657dfa Deployed Aug 26, 2026 by ViktorHofer via pat_pool #735
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants