Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions .github/aw/actions-lock.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
{
"entries": {
"github/gh-aw-actions/setup-cli@v0.82.9": {
"repo": "github/gh-aw-actions/setup-cli",
"version": "v0.82.9",
"sha": "ca8678ca22a7aab577514482576720da641e5661"
},
"github/gh-aw-actions/setup@v0.82.9": {
"github/gh-aw-actions/setup@v0.83.4": {
"repo": "github/gh-aw-actions/setup",
"version": "v0.82.9",
"sha": "ca8678ca22a7aab577514482576720da641e5661"
"version": "v0.83.4",
"sha": "e89c65e17eb281bbd5ff2ff9e9199a03e96654c7"
}
}
}
162 changes: 78 additions & 84 deletions .github/workflows/review-on-open.agent.lock.yml

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions .github/workflows/review-on-open.agent.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ imports:
with:
environment: copilot-pat-pool
- shared/review-shared.md
- .github/agents/expert-reviewer.agent.md

environment: copilot-pat-pool

Expand Down
145 changes: 80 additions & 65 deletions .github/workflows/review.agent.lock.yml

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions .github/workflows/review.agent.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ imports:
with:
environment: copilot-pat-pool
- shared/review-shared.md
- .github/agents/expert-reviewer.agent.md

environment: copilot-pat-pool

Expand Down
17 changes: 12 additions & 5 deletions .github/workflows/shared/review-shared.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,22 @@ safe-outputs:

# Expert Code Review

Review pull request #${{ github.event.pull_request.number || github.event.issue.number }} using the `expert-reviewer` agent defined at `.github/agents/expert-reviewer.agent.md`.
Review pull request #${{ github.event.pull_request.number || github.event.issue.number }}.

The expert MSBuild reviewer instructions — the 24 review dimensions, the 13
overarching principles, and the folder hotspot mapping — are imported into this
prompt from `.github/agents/expert-reviewer.agent.md`. Apply them directly.

## Instructions

1. Fetch the full diff for the pull request.
2. Call the `expert-reviewer` agent. Make sure to call it as subagent (`task` tool, `agent_type: "general-purpose"`, `model: "claude-opus-5"`). And make sure to follow the guidance on subagent calls from within the `expert-reviewer` agent. We expect 2+ levels of agents to be called.
3. Do **not** post comments or reviews yourself, except for the fallback in step 4 if the subagent posts nothing. The subagent will post its own comments using the available safe-output tools:
2. Review the diff yourself, applying every dimension from the reviewer
instructions above. Do not delegate the review to a sub-agent.
Comment on lines +42 to +43
3. Post your findings using the safe-output tools:
- **Inline review comments** on specific diff lines via `create_pull_request_review_comment`
- **Design-level concerns** (not tied to a line) via `add_comment`
- **Final review verdict** (COMMENT or REQUEST_CHANGES) via `submit_pull_request_review`
- **Never use APPROVE** — the agent must not count as a PR approval. Use COMMENT for clean reviews.
4. If the subagent does not post anything (e.g. no issues found), this is the only exception to step 3: post a brief fallback review using `submit_pull_request_review` with event `COMMENT` (not `APPROVE`). Do not use `add_comment` for this fallback.
- **Never use APPROVE** — this review must not count as a PR approval. Use COMMENT for clean reviews.
4. Always finish with `submit_pull_request_review`, including when the diff is
clean. A clean verdict must name the dimensions you actually checked — never
report a pass you did not verify.
Loading