Repository navigation
Core support for AbsolutePath/FileInfo/DirectoryInfo and ITaskItem<T> as task parameters #13971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
7e4e244
support binding to AbsolutePath and AbsolutePath[] for task input/out…
baronfel 8a342ee
Allow users to bind to primitive types while still having access to m…
baronfel bba8cd3
Support FileInfo/DirectoryInfo parameter binding as well
baronfel 0686891
Remove dead #if !TASKHOST guards from TaskParameterTypeVerifier
baronfel 4c1bdf2
Fix task host crash serializing typed task outputs
baronfel bdf2ef3
Fix TaskItem<T> parse errors surface as InvalidProjectFileException
baronfel 2c481c8
Use mutable TaskItem backing for TaskItem<T>
baronfel 5a4db7e
Use FullPath metadata for path-like T in TaskItem<T>
baronfel ef3b4ee
Use EqualityComparer<T>.Default in TaskItem<T> equality
baronfel ce1ff32
Ensure ITaskItem<T>[] arrays are recognized in TaskParameterTypeVerifier
baronfel 90ef8e2
Fix TaskItem<T>[] output type verification
baronfel 54e6df4
Restrict ITaskItem<T> binding to path-like types (AbsolutePath, FileI…
baronfel 11b2648
Potential fix for pull request finding
baronfel 7a77c33
Use existing boolean conversion helpers instead of reimplementing
baronfel e150dd5
Update docs to align with parsed value types
baronfel 1ce47a9
Consolidate TaskItem<T> helper logic in shared verifier
baronfel 3548eb0
actually escape set value in wrapped ITaskItem
baronfel 316ee70
fix potential nullrefs on uninitialized TaskItem<T> structs.
baronfel aa28234
Unify task parameter helper logic across hosts
baronfel 9603335
Fix shared task-parameter helpers for TaskHost builds
baronfel ab16052
Address Rainer and Jan review feedback
baronfel 915167e
Rip out abstracted reflection usage in TaskItem<T> creation
baronfel 865d6aa
Fix TaskItem<T> construction to use generic argument, not closed type
baronfel 5888292
Add TestEnvironment.PublishTestFile for collecting CI artifacts
baronfel 67efb90
Fix BuildCheck CustomCheck E2E tests (NU1605 restore downgrade) (#14137)
OvesN 7ddc75c
Add typed-parameter binding benchmark and cache TaskItem<T> construct…
baronfel 0018057
Address review feedback: nullable pragmas, case-insensitive metadata,…
baronfel 3e37eb8
Merge remote-tracking branch 'origin/main' into pr/13971/typed-params…
baronfel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.