Log the start of Static Graph construction#12048
Merged
YuliiaKovalova merged 1 commit intodotnet:mainfrom Jul 2, 2025
Merged
Conversation
Contributor
Author
@dotnet-policy-service agree |
76a4706 to
06545a5
Compare
rainersigwald
approved these changes
Jun 20, 2025
Member
rainersigwald
left a comment
There was a problem hiding this comment.
My only question is what log importance level this should be. In @jeffkl's example where constructing the graph takes 30s, it'd be really nice to see it! But in a lot of smaller repos I'd rather avoid a log line like this.
@baronfel do you have opinions?
I kinda want a deferred message, where we log nothing unless it takes 5s (or something) and then log at high pri. But we don't have anything else that works like that and it sounds kinda annoying!
JanProvaznik
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11166
Context
Changes Made
Log message added
Testing
One test was updated to reflect the change
Notes