Repository navigation
[CI] /review run-tests: fall back to an AZDO_TRIGGER_PAT secret when Entra sign-in is blocked - #40492
Merged
Merged
Conversation
…Entra sign-in is blocked Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kubaflo
temporarily deployed
to
copilot-pat-pool
November 21, 2026 13:21 — with
GitHub Actions
Inactive
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 40492Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 40492" |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
kubaflo
temporarily deployed
to
copilot-pat-pool
November 21, 2026 13:21 — with
GitHub Actions
Inactive
kubaflo
temporarily deployed
to
copilot-pat-pool
November 21, 2026 13:22 — with
GitHub Actions
Inactive
kubaflo
temporarily deployed
to
copilot-pat-pool
November 21, 2026 13:23 — with
GitHub Actions
Inactive
kubaflo
temporarily deployed
to
copilot-pat-pool
November 21, 2026 13:25 — with
GitHub Actions
Inactive
kubaflo
temporarily deployed
to
copilot-pat-pool
November 21, 2026 13:25 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The untested Azure DevOps PAT dispatch path requires maintainer validation of the secret’s identity, queue/cancel permissions, and acceptability under Entra Conditional Access restrictions.
No open issues 🎉
What changed in this PR
Adds optional personal access token authentication for /review run-tests, allowing the CI dispatcher to queue Azure DevOps UI tests when Entra federated sign-in is blocked. This follows the rollout fixes in #40468.
Changes:
- Passes the
AZDO_TRIGGER_PATrepository secret to the dispatch script. - Uses Basic authentication when the secret is present and no explicit token is supplied, preserving explicit bearer-token and OIDC authentication paths.
| File | Description |
|---|---|
.github/workflows/review-run-tests-dispatch.yml |
Exposes the optional PAT secret to the dispatch step. |
.github/scripts/Invoke-RunTests.ps1 |
Adds PAT-based authentication while retaining existing token handling. |
Review effort: Balanced
Contributor
Author
|
@dalexsoto stamp |
1 task done
4 tasks
1 task done
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Target Branch
CI workflow infrastructure follow-up to #40468, so it targets
main.Description of Change
Microsoft Entra currently refuses the federated-identity token exchange with
AADSTS53003(Conditional Access), so/review run-testscannot queuemaui-pr-uitests. When anAZDO_TRIGGER_PATrepository secret exists,Invoke-RunTests.ps1now authenticates to Azure DevOps with it (Basic auth) instead. Without the secret nothing changes: the OIDC exchange is used.Validation: queued build 1693568 for #40437 locally with an Azure CLI token through the same script (queue path works); script parses. The PAT path itself needs the secret (scope: Build read & execute) to be exercised.