Skip to content

[ci] Restore official runtime manifests from transferred packages - #40320

Merged
kubaflo merged 1 commit into
mainfrom
kubaflo-official-manifest-restore
Nov 17, 2026
Merged

kubaflo merged 1 commit into
mainfrom
kubaflo-official-manifest-restore

Conversation

@kubaflo

@kubaflo kubaflo commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Target Branch

This PR is for Initial base
New features, API changes, or .NET 12 work (including .NET 12 fixes) main
.NET 11 servicing fixes net11, for review
Older servicing, release integration, infrastructure, or documentation The branch designated for that work

For .NET 11 fixes, only a maintainer retargets the approved PR to the active
inflight lane and merges it after CI validates that final base. Do not merge
individual fixes directly into net11; agents must not retarget or merge.

This is the explicitly coordinated shared build-infrastructure repair against main. It is independent of #40312 and does not change any candidate, inflight, or other protected branch.

Description of Change

Reuse the exact runtime-manifest NuGet packages already restored by Pack macOS in the dependent internal Pack Windows job:

  • Stage only microsoft.net.workload.*.manifest-* .nupkg files from the existing isolated temp/workload cache into the existing MacNativeArtifacts transfer.
  • Set RuntimeManifestPackageSource to that transferred local directory during internal Windows provisioning. Workloads.csproj uses this explicit source instead of requesting NuGet.org.
  • Retain the NuGet.org v3 default for public/local final-runtime restores and the existing configured feeds for prerelease restores. Existing additional sources are preserved.

No network-isolation policy, SDK/runtime/package pin, signing, or publication setting changes. A missing local artifact fails explicitly rather than silently falling back to NuGet.org or substituting another package version.

Failure evidence: official dotnet-maui build 3137912, at this PR's exact main base df3291c7610d36940be9c640a809824c3d95f842, fails in Windows Provision SDK & Workloads. Raw log 175 reports NU1301 for https://api.nuget.org/v3/index.json, rejected by the CFSClean proxy with HTTP 403. The macOS pack passes. This PR addresses that restore failure, not the build's separate OneLocBuild failure.

This complements #40159 rather than reverting its public-CI repair: removing NuGet.org without supplying the exact packages reproduces NU1102 for all four final 11.0.100 runtime manifests. SDK-bundled manifests are not a safe replacement based on version labels alone: this exact main SDK bundles net10 manifests labeled 11.0.100 referencing 10.0.12, whereas the requested NuGet packages reference 10.0.15. The transfer preserves the actual requested package bytes.

Searched upstream open and recently merged PRs for the manifest/bootstrap files and NU1301, including release/inflight-targeted changes. No duplicate package-transfer fix was found; #40060's next-major migration is a separate change.

Validation

Fix commit: 1370889ea4e9388c99ec82f2ede6291e232335d4.

The original official Windows restore failure is empirically fixed. dotnet-maui build 3138084 (20261116.5) runs this exact fix SHA on the isolated internal ref validation/official-manifest-restore-1370889ea4, with the normal official CFSClean policy unchanged. Raw logs retrieved with az devops invoke confirm the complete artifact producer/consumer path:

Official step Raw evidence Result
Stage Runtime Manifest Packages Log 68 Passed; copied exactly four unchanged 11.0.100 runtime .nupkg files.
Windows Download Mac Native Binaries Log 134 Passed; downloaded MacNativeArtifacts into artifacts/bin.
Windows Provision SDK & Workloads Log 135 Passed; Workloads.csproj restored in 825 ms, then Build succeeded, 0 warnings / 0 errors at 2026-11-17T01:01:36Z.

Public Windows provisioning is preserved. Replacement maui-pr build 1684648, at PR merge SHA 2d5ee4ee327eb719af851be2309d55d68b7a938f, replaces canceled build 1684642. All four Windows Provision SDK & Build BuildTasks tasks passed: raw logs 114, 115, 116, and 117. Log 114 restored Workloads.csproj in 980 ms; each task's SDK and BuildTasks builds completed with 0 warnings / 0 errors.

The existing Pester scripts check is red on both this head and its exact main base. Compared the complete pester-results.xml artifacts from PR run 43988419959 (1370889ea4e9388c99ec82f2ede6291e232335d4) and baseline run 43966407306 (df3291c7610d36940be9c640a809824c3d95f842): both report 2,671 cases and the same 15 failing test identities, with zero new or removed failures. This does not claim Pester is green.

Both full Azure pipelines were still running when this evidence was recorded. No protected main/candidate ref was moved. This feature validation run is not evidence of candidate deployment, complete signing success, or customer publication.

Local fixed-path checks used the repository's exact SDK payload, 11.0.100-rtm.26514.118 / SDK commit a586537b38, and fresh restore directories. $EVIDENCE denotes an isolated session evidence directory; the transferred package directory is artifacts/bin/runtime-manifests.

# Baseline: failed as expected, NU1102 for the four final runtime manifests.
dotnet restore src/DotNet/Dependencies/Workloads.csproj --configfile NuGet.config --no-http-cache --force -p:RestoreAdditionalProjectSources= -p:RestorePackagesPath="$EVIDENCE/baseline-approved-packages/" -p:BaseIntermediateOutputPath="$EVIDENCE/baseline-approved-obj/" --verbosity minimal

# Fixed: passed, all nine exact package downloads, zero warnings/errors.
DOTNET_ROOT="$PWD/.dotnet" RuntimeManifestPackageSource="$PWD/artifacts/bin/runtime-manifests" NUGET_HTTP_CACHE_PATH="$EVIDENCE/fixed-restore-http/" ./.dotnet/dotnet restore src/DotNet/Dependencies/Workloads.csproj --configfile NuGet.config --no-http-cache --force --packages "$EVIDENCE/fixed-restore-packages/" -p:BaseIntermediateOutputPath="$EVIDENCE/fixed-restore-obj/" --verbosity diagnostic

# Real manifest-provisioning target: passed, including child restore and manifest copy.
DOTNET_ROOT="$PWD/.dotnet" RuntimeManifestPackageSource="$PWD/artifacts/bin/runtime-manifests" NUGET_HTTP_CACHE_PATH="$EVIDENCE/provision-http/" ./.dotnet/dotnet msbuild src/DotNet/DotNet.csproj -t:_AcquireWorkloadManifests -p:InstallDotNet=false -p:InstallWorkloadPacks=false -p:Configuration=Release -nologo -verbosity:minimal

# Available prerelease fixture: passed using configured feeds only, without an artifact override.
DOTNET_ROOT="$PWD/.dotnet" NUGET_HTTP_CACHE_PATH="$EVIDENCE/prerelease-http/" ./.dotnet/dotnet restore src/DotNet/Dependencies/Workloads.csproj --configfile NuGet.config --no-http-cache --force --packages "$EVIDENCE/prerelease-packages/" -p:BaseIntermediateOutputPath="$EVIDENCE/prerelease-obj/" -p:MicrosoftNETCoreAppRefPackageVersion=11.0.0-rtm.26480.113 --verbosity minimal

# Configuration syntax/whitespace: all passed.
ruby -ryaml -e 'YAML.parse_file(ARGV[0]); puts "YAML syntax passed"' eng/pipelines/arcade/stage-pack.yml
xmllint --noout src/DotNet/Dependencies/Workloads.csproj
git diff --check

Inspected the successful restore graph: NuGet.org is absent. All four final runtime .nupkg.metadata files name the local artifact source, all four staged packages are byte-identical to their freshly restored originals, and the real provisioning target installs the unchanged current 11.0.0 and previous 10.0.15 pack references. The complete nine-package download requirement set is identical before and after the fix. A separate missing-directory restore fails as expected with explicit NU1301. MSBuild evaluation confirms unchanged stable/prerelease defaults and preservation of pre-existing additional sources.

Local transport limitation: this Mac cannot establish TLS to NuGet.org v3. The local package-staging fixture was acquired using the already-documented NuGet.org v2 restore override; no alternate endpoint is committed or used for the Windows fix. The committed macOS/public default remains v3. Windows runtime/MSI/signing execution is unavailable locally; the official raw-log evidence above independently confirms the complete manifest artifact producer/consumer and Windows provisioning path. No pipeline/configuration tests were added.

Issues Fixed

Repairs the official Windows runtime-manifest restoration failure demonstrated above. No product issue is closed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kubaflo
kubaflo temporarily deployed to copilot-pat-pool November 17, 2026 00:32 — with GitHub Actions Inactive
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 40320

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 40320"

@azure-pipelines

This comment has been minimized.

@kubaflo
kubaflo temporarily deployed to copilot-pat-pool November 17, 2026 00:32 — with GitHub Actions Inactive
@kubaflo
kubaflo temporarily deployed to copilot-pat-pool November 17, 2026 00:34 — with GitHub Actions Inactive
@kubaflo
kubaflo temporarily deployed to copilot-pat-pool November 17, 2026 00:36 — with GitHub Actions Inactive
@kubaflo
kubaflo temporarily deployed to copilot-pat-pool November 17, 2026 00:37 — with GitHub Actions Inactive
@github-actions github-actions Bot added area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions platform/macos macOS / Mac Catalyst platform/windows labels Nov 17, 2026
@kubaflo
kubaflo temporarily deployed to copilot-pat-pool November 17, 2026 00:38 — with GitHub Actions Inactive
@kubaflo

This comment has been minimized.

@github-actions github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Nov 17, 2026
@kubaflo

kubaflo commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

/rebase

@kubaflo

This comment has been minimized.

@azure-pipelines

This comment has been minimized.

@MauiBot

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expert Review — 1 finding

Reviewed commit 1370889.

See inline comments for details.

<!-- Final runtime manifests are published to NuGet.org rather than the build feeds. -->
<RestoreAdditionalProjectSources Condition="'$(_RuntimeManifestVersion)' == '$(VersionBand)'">$(RestoreAdditionalProjectSources);https://api.nuget.org/v3/index.json</RestoreAdditionalProjectSources>
<!-- Isolated builds can supply the exact runtime packages locally instead of using NuGet.org. -->
<RuntimeManifestPackageSource Condition="'$(RuntimeManifestPackageSource)' == '' and '$(_RuntimeManifestVersion)' == '$(VersionBand)'">https://api.nuget.org/v3/index.json</RuntimeManifestPackageSource>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[moderate] Regression Prevention and Test Coverage - The new source-selection branches have no committed regression coverage. Public Pack never supplies this override, and the existing DotNetProjectTests only evaluates installation paths, so those checks cannot catch NuGet.org being reintroduced into the isolated Windows restore. Add property-evaluation cases for stable manifests with a local override (local source present, NuGet.org absent), stable manifests without an override (NuGet.org retained), and prerelease manifests without an override (no added source), including preservation of existing additional sources. The existing MSBuild property-evaluation test infrastructure can exercise these conditions without signing or device execution.

@MauiBot MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Nov 17, 2026
@kubaflo
kubaflo marked this pull request as ready for review November 17, 2026 01:06
Copilot AI balanced review requested due to automatic review settings November 17, 2026 01:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the runtime-manifest package-transfer changes.

No open issues 🎉

What changed in this PR

Repairs official Windows workload provisioning by reusing the exact runtime-manifest packages restored by Pack macOS, avoiding blocked NuGet.org access without changing package versions.

Changes:

  • Stage runtime-manifest packages in the existing macOS artifact transfer for internal builds.
  • Use the transferred directory during internal Windows provisioning while preserving public/local and prerelease restore defaults.
  • Document the official package-transfer path and the requirement to preserve exact package contents.
File Description
src/​DotNet/​Dependencies/​Workloads.csproj Adds a configurable runtime-manifest source while retaining the final-runtime NuGet.org default.
eng/​pipelines/​arcade/​stage-pack.yml Stages macOS-restored packages and configures internal Windows provisioning to consume them.
.github/​docs/​maui-ci-facts.md Documents the transfer mechanism and exact-package requirements.

Review effort: Balanced

@kubaflo

This comment has been minimized.

@github-actions github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Nov 17, 2026
@MauiBot

This comment has been minimized.

@MauiBot MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Nov 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expert Review — 1 finding

Reviewed commit 1370889.

See inline comments for details.

<!-- Final runtime manifests are published to NuGet.org rather than the build feeds. -->
<RestoreAdditionalProjectSources Condition="'$(_RuntimeManifestVersion)' == '$(VersionBand)'">$(RestoreAdditionalProjectSources);https://api.nuget.org/v3/index.json</RestoreAdditionalProjectSources>
<!-- Isolated builds can supply the exact runtime packages locally instead of using NuGet.org. -->
<RuntimeManifestPackageSource Condition="'$(RuntimeManifestPackageSource)' == '' and '$(_RuntimeManifestVersion)' == '$(VersionBand)'">https://api.nuget.org/v3/index.json</RuntimeManifestPackageSource>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[moderate] Regression Prevention and Test Coverage - The source-selection branches have no committed regression coverage. Public Pack does not supply the override, and DotNetProjectTests only evaluates installation paths: neither detects NuGet.org being appended alongside the local override, which would reintroduce the original isolated Windows NU1301/HTTP 403 failure. Conversely, removing the stable default would undo #40159's NU1102 repair for public/macOS provisioning. Add MSBuild property-evaluation cases for stable manifests with a local override (local source present, NuGet.org absent), stable manifests without an override (NuGet.org retained), and prerelease manifests without an override (no added source), asserting preservation of existing additional sources. The existing DotNetProjectTests evaluation infrastructure can cover this matrix without signing or device execution.

@kubaflo

kubaflo commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

@dalexsoto stamp

@kubaflo

This comment has been minimized.

@github-actions github-actions Bot added the s/agent-review-in-progress AI review is currently running for this PR label Nov 17, 2026
@MauiBot

MauiBot commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

PR Test Gate

@kubaflo — existing-test verification for commit 1370889e.

Result INCONCLUSIVE Platform MacCatalyst Commit 1370889e


🧪 Gate analysis — click to expand

⚠ Inconclusive. Setup, build, or execution did not produce a conclusive result. This does not prove the fix is incorrect.

No interpretable test-group summary was produced. No additional test execution is inferred.

PR head: 1370889e.

Without-fix baseline: 264778ab.

@MauiBot MauiBot removed the s/agent-review-in-progress AI review is currently running for this PR label Nov 17, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expert Review — 1 finding

Reviewed commit 1370889.

See inline comments for details.

<!-- Final runtime manifests are published to NuGet.org rather than the build feeds. -->
<RestoreAdditionalProjectSources Condition="'$(_RuntimeManifestVersion)' == '$(VersionBand)'">$(RestoreAdditionalProjectSources);https://api.nuget.org/v3/index.json</RestoreAdditionalProjectSources>
<!-- Isolated builds can supply the exact runtime packages locally instead of using NuGet.org. -->
<RuntimeManifestPackageSource Condition="'$(RuntimeManifestPackageSource)' == '' and '$(_RuntimeManifestVersion)' == '$(VersionBand)'">https://api.nuget.org/v3/index.json</RuntimeManifestPackageSource>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[moderate] Regression Prevention and Test Coverage - The source-selection branches have no committed regression coverage. Public Pack omits the local override, and DotNetProjectTests only evaluates installation paths; neither asserts that NuGet.org is absent when isolated Windows provisioning supplies RuntimeManifestPackageSource. Appending NuGet.org alongside that override would reintroduce the original NU1301/HTTP 403 failure, while dropping the stable default would undo #40159's NU1102 repair for public/local and macOS provisioning. Add MSBuild property-evaluation cases for stable manifests with a local override (local source present, NuGet.org absent), stable manifests without an override (NuGet.org retained), and prerelease manifests without an override (no added source), asserting that existing additional sources are preserved. The committed DotNetProjectTests property-evaluation pattern can cover these branches without signing or device execution.

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping as requested by @kubaflo; no code review performed.

@kubaflo
kubaflo merged commit 8744f99 into main Nov 17, 2026
46 of 93 checks passed
@kubaflo
kubaflo deleted the kubaflo-official-manifest-restore branch November 17, 2026 12:46

This branch was previously deployed

1 inactive deployment
copilot-pat-pool — 1370889e Deployed Nov 17, 2026 by kubaflo via conclusion #3029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions platform/macos macOS / Mac Catalyst platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants