-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Proposal - Replace internal use of MessagingCenter #3880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
de967b9
testing moving the Android page stuff
hartez 39867d8
Update the Page stuff for all platforms
hartez 6cb67bb
Replace the rest of the MC stuff
hartez 4a01020
Convert message classes to records
hartez c4e8f49
Don't make empty classes into records
hartez 63a4020
Fix some closures and method group usage
hartez b425af7
Mark lambdas static
hartez ca9f0d7
Clean up more closures and method groups
hartez b5125da
Update NuGet.config
Redth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| // https://docs.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.isexternalinit?view=net-5.0 | ||
| // https://developercommunity.visualstudio.com/t/error-cs0518-predefined-type-systemruntimecompiler/1244809 | ||
| // Adding this because at least one of the target frameworks doesn't include it; hopefully we can drop this at some point | ||
| // (and hopefully before release) | ||
| // TODO ezhart Evaluate whether we still need this | ||
| namespace System.Runtime.CompilerServices | ||
| { | ||
| internal static class IsExternalInit { } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| namespace Microsoft.Maui.Controls | ||
| { | ||
| internal abstract record RadioButtonScopeMessage(Element Scope); | ||
|
|
||
| internal sealed record RadioButtonGroupSelectionChanged(Element Scope, RadioButton RadioButton) | ||
| : RadioButtonScopeMessage(Scope); | ||
|
|
||
| internal sealed record RadioButtonGroupNameChanged(Element Scope, string OldName) | ||
| : RadioButtonScopeMessage(Scope); | ||
|
|
||
| internal sealed record RadioButtonValueChanged(Element Scope, RadioButton RadioButton) | ||
| : RadioButtonScopeMessage(Scope); | ||
|
|
||
| internal sealed record RadioButtonGroupValueChanged (Element Scope, object Value, string GroupName) | ||
| : RadioButtonScopeMessage(Scope); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.