Document rebase complexity and recommend resolution strategy for PR #29952#34008
Closed
Copilot wants to merge 104 commits intodev/simonrozsival/net10.0-use-element-handler-attributesfrom
Closed
Document rebase complexity and recommend resolution strategy for PR #29952#34008Copilot wants to merge 104 commits intodev/simonrozsival/net10.0-use-element-handler-attributesfrom
Copilot wants to merge 104 commits intodev/simonrozsival/net10.0-use-element-handler-attributesfrom
Conversation
…Enabled to RuntimeFeature
- Add StyleSheetTrimmerWarning constant to StyleSheet.cs - Update all RUC attributes to use the constant instead of TODO - Mark CSS StyleSheets as a trimming-unsafe feature
- Add EventTriggerTrimmingWarning constant with proper justification - Add internal EventTrigger<T> prototype for trimming/AOT-safe alternative - EventTrigger<T> uses delegates instead of reflection for event subscription
- Add EventTriggerTrimmingWarning constant with proper justification - Reference EventTrigger<T> as future trimming/AOT-safe alternative
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update trimmable element handlers for controls
Document rebase complexity and recommend resolution strategy for PR #29952
Feb 12, 2026
4dbc042 to
b8a94ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #29952 (trimmable element handlers) requires rebasing 103 commits from
dev/simonrozsival/net10.0-use-element-handler-attributesontonet11.0. The branches have grafted history with no common ancestor, resulting in 1,040 conflicting files.Analysis
Branch structure:
[ElementHandler]attributes6ab474e953with no parent historynet11.0Conflict breakdown:
.github/,eng/, pipeline configsglobal.json,NuGet.config, version filesAttempted Approaches
git rebase net11.0- Failed (no merge-base)git merge- Failed (no common ancestor)git am --3way- Stopped at 1,040 conflictsRecommended Paths
Option 1: Selective cherry-pick (fastest, cleanest)
Option 2: Automated conflict resolution (systematic but risky)
.github/,eng/, templates, configssrc/Core/,src/Controls/handler filesOption 3: Manual port (most reliable)
Decision Required
The core functionality (handler attributes replacing DI registration) is straightforward to port. The challenge is 1,000+ incidental conflicts from parallel development. Guidance needed on preferred conflict resolution strategy.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.