Fix CodeDom reference #3339
Fix CodeDom reference #3339
Conversation
I noticed that in my Maui application System.CodeDom was being referenced. This is because we don't have a `PrivateAssets="all"` on the PackageReference in Microsoft.Maui.Controls.Build.Tasks.csproj. This causes a problem when submitting an app to the Apple App Store, because CodeDom is preventing some unnecessary System.Diagnostics.Process code from being trimmed. Adding the PrivateAssets="all", and removing unnecessary Conditions since this project only builds for netstandard2.0. Fix dotnet#3290 Fix dotnet/runtime#61265
|
Is it feasible to protect this with a test somehow -- since it already regressed? |
|
No good ideas come to mind. Do we have some tests that verify nuget packages? A crazy idea would be to build an app and ensure System.CodeDom isn't referenced by default. |
|
I see Maybe we can add a step after that: <PackageReference Include="@(PackageReference)" PrivateAssets="all" />Not sure if that works because packages are special. |
Yes, I just noticed that too. Let me see if I can fix it for good. |
|
OK, I got something to work where locally I also went ahead and changed PTAL |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
samhouts
added
the
fixed-in-6.0.101-preview.11.3
4 participants
I noticed that in my Maui application System.CodeDom was being referenced. This is because we don't have a
PrivateAssets="all"on the PackageReference in Microsoft.Maui.Controls.Build.Tasks.csproj.This causes a problem when submitting an app to the Apple App Store, because CodeDom is preventing some unnecessary System.Diagnostics.Process code from being trimmed.
Adding the PrivateAssets="all", and removing unnecessary Conditions since this project only builds for netstandard2.0.
Fix #3290
Fix dotnet/runtime#61265
Reimplementing the fix from #888
cc @Redth @PureWeen