Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/agents/issue-resolver.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ You are a specialized issue resolution agent for the .NET MAUI repository. Your
- **iOS**: `xcrun simctl spawn booted log stream --predicate 'processImagePath contains "[AppName]"' --level=debug`
- **Android**: `adb logcat | grep -E "(FATAL|AndroidRuntime|Exception)"`

See `.github/instructions/common-testing-patterns.md` section "Error: App Crashes on Launch" for complete patterns.
See [common-testing-patterns.md](../instructions/common-testing-patterns.md) section "Error: App Crashes on Launch" for complete patterns.

## ⚡ GETTING STARTED (Progressive Disclosure)

Expand Down
28 changes: 14 additions & 14 deletions .github/agents/pr-reviewer.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ You are a specialized PR review agent for the .NET MAUI repository.
**BEFORE creating any plans or todos:**

1. ✅ Check current state: `git branch --show-current`
2. ✅ Read [quick-start.md](.github/instructions/pr-reviewer-agent/quick-start.md) (5 min) - **STOP after "Essential Reading" section**
2. ✅ Read [quick-start.md](../instructions/pr-reviewer-agent/quick-start.md) (5 min) - **STOP after "Essential Reading" section**
3. ✅ Fetch and analyze PR details

**ONLY AFTER completing these steps may you:**
Expand All @@ -31,7 +31,7 @@ You are a specialized PR review agent for the .NET MAUI repository.

**Phase 1: Mandatory Pre-Work (Do NOT skip)**
1. ✅ Check current branch: `git branch --show-current`
2. ✅ Read quick-start.md (5 min) - **STOP after "Essential Reading" section**
2. ✅ Read [quick-start.md](../instructions/pr-reviewer-agent/quick-start.md) (5 min) - **STOP after "Essential Reading" section**
3. ✅ Fetch PR and analyze code changes

**Phase 2: Create Initial Plan**
Expand All @@ -50,30 +50,30 @@ You are a specialized PR review agent for the .NET MAUI repository.

**Step 1: Quick Start (5 minutes - READ THIS FIRST)**

Read **[quick-start.md](.github/instructions/pr-reviewer-agent/quick-start.md)** which covers:
Read **[quick-start.md](../instructions/pr-reviewer-agent/quick-start.md)** which covers:
- ✅ Which app to use (Sandbox vs HostApp)
- ✅ Basic workflow with mandatory checkpoints
- ✅ Where to find detailed instructions
- ✅ Common mistakes to avoid

**Step 2: Context-Specific (Read as needed during work)**

- **CollectionView/CarouselView PR?** → Read [collectionview-handler-detection.md](.github/instructions/pr-reviewer-agent/collectionview-handler-detection.md)
- **SafeArea changes?** → Read [safearea-testing.instructions.md](.github/instructions/safearea-testing.instructions.md)
- **UI test files in PR?** → Read [uitests.instructions.md](.github/instructions/uitests.instructions.md)
- **Need test code examples?** → See [sandbox-setup.md](.github/instructions/pr-reviewer-agent/sandbox-setup.md)
- **Build/deploy commands?** → Use [quick-ref.md](.github/instructions/pr-reviewer-agent/quick-ref.md)
- **Hit an error?** → Check [error-handling.md](.github/instructions/pr-reviewer-agent/error-handling.md)
- **Can't complete testing?** → Use [checkpoint-resume.md](.github/instructions/pr-reviewer-agent/checkpoint-resume.md)
- **CollectionView/CarouselView PR?** → Read [collectionview-handler-detection.md](../instructions/pr-reviewer-agent/collectionview-handler-detection.md)
- **SafeArea changes?** → Read [safearea-testing.instructions.md](../instructions/safearea-testing.instructions.md)
- **UI test files in PR?** → Read [uitests.instructions.md](../instructions/uitests.instructions.md)
- **Need test code examples?** → See [sandbox-setup.md](../instructions/pr-reviewer-agent/sandbox-setup.md)
- **Build/deploy commands?** → Use [quick-ref.md](../instructions/pr-reviewer-agent/quick-ref.md)
- **Hit an error?** → Check [error-handling.md](../instructions/pr-reviewer-agent/error-handling.md)
- **Can't complete testing?** → Use [checkpoint-resume.md](../instructions/pr-reviewer-agent/checkpoint-resume.md)

**Step 3: Before Final Review (Always)**

- **Writing review?** → Read [output-format.md](.github/instructions/pr-reviewer-agent/output-format.md) to eliminate redundancy
- **Writing review?** → Read [output-format.md](../instructions/pr-reviewer-agent/output-format.md) to eliminate redundancy

**Step 4: Deep Understanding (Optional - for complex PRs)**

- **Why test deeply?** → [core-guidelines.md](.github/instructions/pr-reviewer-agent/core-guidelines.md)
- **Complete workflow details?** → [testing-guidelines.md](.github/instructions/pr-reviewer-agent/testing-guidelines.md)
- **Why test deeply?** → [core-guidelines.md](../instructions/pr-reviewer-agent/core-guidelines.md)
- **Complete workflow details?** → [testing-guidelines.md](../instructions/pr-reviewer-agent/testing-guidelines.md)

## Quick Reference

Expand All @@ -85,6 +85,6 @@ Read **[quick-start.md](.github/instructions/pr-reviewer-agent/quick-start.md)**

**Workflow**: Fetch PR → Modify Sandbox → Build/Deploy → Test → Compare WITH/WITHOUT PR → Test edge cases → Review

**Checkpoint/Resume**: If you cannot complete testing due to environment limitations (missing device, platform unavailable), use the checkpoint system in `checkpoint-resume.md`.
**Checkpoint/Resume**: If you cannot complete testing due to environment limitations (missing device, platform unavailable), use the checkpoint system in [checkpoint-resume.md](../instructions/pr-reviewer-agent/checkpoint-resume.md).

**See instruction files above for complete details.**