Skip to content

[Blazor] Clean up duplicate path normalization code in HybridWebView #30873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Aug 4, 2025
Merged

[Blazor] Clean up duplicate path normalization code in HybridWebView #30873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/Core/src/Platform/Android/MauiHybridWebViewClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
using System.Web;
using Android.Webkit;
using Microsoft.Extensions.Logging;
using Microsoft.Maui.Storage;
using AWebView = Android.Webkit.WebView;

namespace Microsoft.Maui.Platform
Expand Down Expand Up @@ -112,7 +113,7 @@ public MauiHybridWebViewClient(HybridWebViewHandler handler)
return null;
}

filename = PathUtils.NormalizePath(filename);
filename = FileSystemUtils.NormalizePath(filename);
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces a local PathUtils.NormalizePath method with FileSystemUtils.NormalizePath, which could be a breaking change if the behavior differs between implementations. Please verify that FileSystemUtils.NormalizePath has identical behavior to the removed PathUtils.NormalizePath method, and alert reviewers that this is potentially a breaking change.

Copilot uses AI. Check for mistakes.

try
{
Expand All @@ -123,15 +124,7 @@ public MauiHybridWebViewClient(HybridWebViewHandler handler)
return null;
}
}

internal static class PathUtils
{
public static string NormalizePath(string filename) =>
filename
.Replace('\\', Path.DirectorySeparatorChar)
.Replace('/', Path.DirectorySeparatorChar);
}


private protected static IDictionary<string, string> GetHeaders(string contentType) =>
new Dictionary<string, string> {
{ "Content-Type", contentType },
Expand Down
Loading