Skip to content

Fix for SafeArea management on iOS Failing test case - LabelShouldSizeProperlyOnCollectionView #30682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 8 commits into from
Jul 17, 2025
Merged

Fix for SafeArea management on iOS Failing test case - LabelShouldSizeProperlyOnCollectionView #30682

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6b92b53
Fix SafeArea management on iOS
PureWeen Jul 10, 2025
e78008b
Fixed the SafeArea branch test case failures issues (#30622)
Ahamed-Ali Jul 15, 2025
3900c78
Enhance CrossPlatformArrange method to support safe area adjustments …
PureWeen Jul 15, 2025
e012b4f
- add images and fix naming
PureWeen Jul 15, 2025
3c738c4
- additional image updates
PureWeen Jul 15, 2025
4c191ea
- add comments
PureWeen Jul 16, 2025
b66879f
Merge branch 'PureWeen/safe-area-fixes-ios-net10' of https://github.c…
praveenkumarkarunanithi Jul 17, 2025
3e43107
fix update.
praveenkumarkarunanithi Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/Core/src/Platform/iOS/SafeAreaPadding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using CoreGraphics;
using UIKit;
using System;

namespace Microsoft.Maui.Platform;

Expand Down Expand Up @@ -28,6 +29,18 @@ public CGRect InsetRect(CGRect bounds)

internal static class SafeAreaInsetsExtensions
{
public static SafeAreaPadding ToSafeAreaInsets(this UIEdgeInsets insets) =>
new(insets.Left, insets.Right, insets.Top, insets.Bottom);
public static SafeAreaPadding ToSafeAreaInsets(this UIEdgeInsets insets)
{
// Filters out negligible floating-point values from UIKit that may cause layout issues (e.g., 3.5527136788005009e-15).
const double tolerance = 1e-14;

static double ApplyTolerance(double value) => Math.Abs(value) < tolerance ? 0 : value;

return new(
ApplyTolerance(insets.Left),
ApplyTolerance(insets.Right),
ApplyTolerance(insets.Top),
ApplyTolerance(insets.Bottom)
);
}
}