Fix StrokeDashArray on Border does not reset when set to null by devanathan-vaithiyanathan · Pull Request #29910 · dotnet/maui

devanathan-vaithiyanathan · 2025-06-10T17:16:29Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details:

Setting Border.StrokeDashArray to null does not remove the previously applied dash pattern, causing the dashed border to remain visible.

Description of Change

Handled the case where StrokeDashArray is set to null by resetting the native dash pattern to ensure the stroke renders as a solid line.

Issues Fixed

Fixes #29898
Fixes #22326

Tested the behavior in the following platforms.

Android
Windows
iOS
Mac

Before	After
iOS iOS-BeforeFix.mov	iOS iOS-AfterFix.mov

dotnet-policy-service · 2025-06-10T17:16:47Z

Hey there @@devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-06-11T10:36:57Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-11T10:37:09Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR fixes an issue where setting Border.StrokeDashArray to null (or an empty array) did not clear the previously applied dash pattern on iOS and macOS Catalyst. It adds matching logic on Windows and Android platforms and includes a new UI sample and automated tests to verify the behavior.

Handle null/empty dash arrays in the iOS MauiCALayer implementation
Mirror the “clear dash” logic in Windows and Android renderers
Add a sample page and UI tests to confirm both clearing and setting dash patterns

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Core/src/Platform/iOS/MauiCALayer.cs	Reset `_strokeDash` to null when dash array is null or empty
src/Core/src/Platform/Windows/StrokeExtensions.cs	Remove early return so null dash arrays propagate to `UpdateStrokeDashPattern`
src/Core/src/Platform/Windows/BorderExtensions.cs	Clear `StrokeDashArray` on null/empty dash arrays
src/Core/src/Graphics/MauiDrawable.Android.cs	Reset `_borderPathEffect` and clear paint path effect on null/empty
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29898.cs	Add UI tests for “Clear” and “Set” dash buttons
src/Controls/tests/TestCases.HostApp/Issues/Issue29898.cs	Add sample page with Clear/Set buttons for manual testing

Comments suppressed due to low confidence (2)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29898.cs:21

Consider adding a third test that sets StrokeDashArray to an empty collection (new DoubleCollection()) to verify that the empty-array branch also correctly clears the dash pattern.

VerifyScreenshot();

src/Controls/tests/TestCases.HostApp/Issues/Issue29898.cs:19

[nitpick] The local variables button and button2 are ambiguous; consider renaming them to clearDashButton and setDashButton for better readability.

var button = new Button

Copilot · 2025-06-11T11:47:09Z

src/Core/src/Platform/Windows/BorderExtensions.cs

 			}
+			else if (borderDashArray is null || borderDashArray.Length == 0)
+			{
+				borderPath.StrokeDashArray = null;


Assigning StrokeDashArray to null may lead to NullReferenceExceptions when the path renders. It’s safer to call borderPath.StrokeDashArray.Clear() to preserve a valid collection object.

Suggested change

borderPath.StrokeDashArray = null;

if (borderPath.StrokeDashArray == null)

borderPath.StrokeDashArray = new WDoubleCollection();

borderPath.StrokeDashArray.Clear();

Copilot · 2025-06-11T11:47:09Z

src/Core/src/Graphics/MauiDrawable.Android.cs

 				_borderPathEffect = null;
+				if (_borderPaint != null)
+				{
+					_borderPaint.SetPathEffect(null);


After clearing the path effect on the paint, call InvalidateSelf() (or the equivalent) on the drawable to ensure the UI is redrawn immediately.

Suggested change

_borderPaint.SetPathEffect(null);

_borderPaint.SetPathEffect(null);

InvalidateSelf();

InvalidateSelf(); is invoked in line 311

jsuarezruiz · 2025-06-23T13:27:12Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-23T13:27:24Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-06-23T13:36:30Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29898.cs

+	{
+		App.WaitForElement("SetDashButton");
+		App.Tap("SetDashButton");
+		VerifyScreenshot();


Pending snapshots. Running a build.

Snapshots available in the latest build.

@jsuarezruiz , I have added the pending snapshot.

jsuarezruiz · 2025-06-30T07:08:50Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-30T07:09:04Z

Azure Pipelines successfully started running 1 pipeline(s).

github-actions · 2025-12-09T07:57:50Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 29910

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 29910"

dotnet-policy-service bot added the community ✨ Community Contribution label Jun 10, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jun 10, 2025

jsuarezruiz added platform/ios area-controls-border Border labels Jun 11, 2025

devanathan-vaithiyanathan changed the title ~~[iOS, macOS] Fix StrokeDashArray on Border does not reset when set to null~~ Fix StrokeDashArray on Border does not reset when set to null Jun 11, 2025

devanathan-vaithiyanathan marked this pull request as ready for review June 11, 2025 11:45

Copilot AI review requested due to automatic review settings June 11, 2025 11:45

sheiksyedm added platform/windows platform/android labels Jun 11, 2025

devanathan-vaithiyanathan requested a review from a team as a code owner June 11, 2025 11:45

devanathan-vaithiyanathan requested review from jfversluis and jsuarezruiz June 11, 2025 11:45

Copilot AI reviewed Jun 11, 2025

View reviewed changes

devanathan-vaithiyanathan mentioned this pull request Jun 19, 2025

StrokeDashArray of a Border control is not well recycled with a CollectionView #22326

Open

jsuarezruiz reviewed Jun 23, 2025

View reviewed changes

devanathan-vaithiyanathan added 8 commits December 9, 2025 13:27

fix added

ad1176b

test case added

9384266

condition updated

38d444c

android fix added

302f207

Windows fix added

b4d894f

condition updated

e69f505

alignment updated

96759ca

Test sample modified

9c5b3a8

devanathan-vaithiyanathan added 2 commits December 9, 2025 13:27

snapshot added

e43c574

mac snapshot added

0b43994

devanathan-vaithiyanathan force-pushed the fix-29898 branch from c47278b to 0b43994 Compare December 9, 2025 07:57

-				borderPath.StrokeDashArray = null;
+				if (borderPath.StrokeDashArray == null)
+					borderPath.StrokeDashArray = new WDoubleCollection();
+				borderPath.StrokeDashArray.Clear();

	_borderPaint.SetPathEffect(null);
	_borderPaint.SetPathEffect(null);
	InvalidateSelf();

Conversation

devanathan-vaithiyanathan commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details:

Description of Change

Issues Fixed

Uh oh!

dotnet-policy-service bot commented Jun 10, 2025

Uh oh!

jsuarezruiz commented Jun 11, 2025

Uh oh!

azure-pipelines bot commented Jun 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jun 23, 2025

Uh oh!

azure-pipelines bot commented Jun 23, 2025

Uh oh!

jsuarezruiz Jun 23, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

devanathan-vaithiyanathan Jun 25, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jun 30, 2025

Uh oh!

azure-pipelines bot commented Jun 30, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

devanathan-vaithiyanathan commented Jun 10, 2025 •

edited

Loading