[NET10] Enable Nullability on ShellPageRendererTracker#28441
[NET10] Enable Nullability on ShellPageRendererTracker#28441
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables nullability on ShellPageRendererTracker and updates related iOS renderer classes to improve null-safety. Key changes involve enabling #nullable in ShellPageRendererTracker, updating property types and event handler signatures to account for nullability, and minor refactoring in UIContainerView.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/UIContainerView.cs | Minor refactoring in Disconnect with added null-safety handling. |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs | Enabled #nullable, updated properties and event handler signatures, and adjusted toolbar/search handling for nullability. |
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs:835
- Method name 'DettachSearchController' contains a typo; please consider renaming it to 'DetachSearchController'.
void DettachSearchController()
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
|
|
||
| public bool IsRootPage { get; set; } | ||
|
|
||
| #nullable disable |
There was a problem hiding this comment.
why are adding this here instead of fixing the all file?
There was a problem hiding this comment.
Because this properties are implementing the IShellPageRendererTracker interface. To add nullability here, we need to update the interface too.
|
/rebase |
rmarinho
left a comment
There was a problem hiding this comment.
Can we make sure we add brackets to all ifs ?
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Show resolved
Hide resolved
…geRendererTracker.cs Co-authored-by: Rui Marinho <[email protected]>
…geRendererTracker.cs Co-authored-by: Rui Marinho <[email protected]>
…geRendererTracker.cs Co-authored-by: Rui Marinho <[email protected]>
…geRendererTracker.cs Co-authored-by: Rui Marinho <[email protected]>
…geRendererTracker.cs Co-authored-by: Rui Marinho <[email protected]>
…geRendererTracker.cs Co-authored-by: Rui Marinho <[email protected]>
Have done the changes, could you review it again? |
|
/rebase |

Description of Change
Enable Nullability on
ShellPageRendererTracker.Issues Fixed
Fixes #27162