Closed
Conversation
albyrock87
commented
Mar 10, 2025
| <Entry AutomationId="entry" Background="Green"></Entry> | ||
| <Label AutomationId="label" Text="If you can't interact with the above entry field, the test has failed" LineBreakMode="CharacterWrap"></Label> | ||
| </VerticalStackLayout> | ||
| </ContentPage> No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
This is the goal of this UITest, the entry should be visible and the user should be able to interact with it.
Member
There was a problem hiding this comment.
I was curious what this looked like on main so if anyone else was wondering :)
edit: this is already here: #28264
albyrock87
force-pushed
the
safe-area-fixes-ios
branch
from
8aa94cb to
8b2d34a
Compare
PureWeen
added
the
p/0
pictos
reviewed
Mar 11, 2025
albyrock87
force-pushed
the
safe-area-fixes-ios
branch
2 times, most recently
from
c905317 to
65a33cb
Compare
tj-devel709
previously approved these changes
Mar 14, 2025
github-project-automation
bot
moved this from Ready To Review
to Approved
in MAUI SDK Ongoing
albyrock87
force-pushed
the
safe-area-fixes-ios
branch
from
65a33cb to
5125c01
Compare
PureWeen
force-pushed
the
safe-area-fixes-ios
branch
from
5125c01 to
c4f06b5
Compare
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Closed
PureWeen
force-pushed
the
safe-area-fixes-ios
branch
from
c4f06b5 to
20d3975
Compare
jfversluis
added
the
area-layout
Member
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # src/Controls/src/Core/Page/Page.cs # src/Core/src/Platform/iOS/MauiScrollView.cs # src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt # src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
PureWeen
force-pushed
the
safe-area-fixes-ios
branch
from
f279dae to
e8e981d
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This is an alternative/cumulative solution for both #27839 and #28264.
Regarding the
MauiScrollViewone, the fix simply checks whether theMauiScrollViewlives inside anotherUIScrollView.In such case we can give for granted that the ancestor one is properly accounting for safe area.
Regarding safe area, the main problem is that MAUI was measuring the content without accounting for the safe area.
This PR makes the
SizeThatFitssmarter by accounting for safe area adjustments:Then when arranging we can simply adjust for safe area using the cached thickness.
We only need to pay attention when the
SafeAreaInsetschange and trigger an invalidation of the ancestors.Thanks to @PureWeen suggestion to set
RespondsToSafeAreatofalsewhen the view is a descendant of aUIScrollView.Issues Fixed
Fixes #27715
Fixes #24246