[iOS/Mac] Fixed the Border Rendering issues in CollectionViewHandler2 by Ahamed-Ali · Pull Request #27801 · dotnet/maui

Ahamed-Ali · 2025-02-14T15:33:10Z

Root Cause of the issue

The Virtual View is not arranged in TemplatedCell2, causing some items to render improperly while scrolling in cv2.

Description of Change

Properly arranged the Virtual View prevents border shape deformation during scrolling and ensures correct rendering in cv2.

Same Changes of PR merged into Main

#28225 Since the same changes in this PR were already merged into the main branch in LayoutSubviews, I have kept only the test.

Issues Fixed

Fixes #27608

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Screenshot

Polygon

Before Issue Fix	After Issue Fix
PolygonIssue.mov	Polygonfixed.mov

RoundRectangle

Before Issue Fix	After Issue Fix
RoundRectangleIssue.mov	RoundRectangleFix.mov

dotnet-policy-service · 2025-02-14T15:33:30Z

Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-02-17T07:03:02Z

/azp run

azure-pipelines · 2025-02-17T07:03:30Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-17T10:13:15Z

/azp run

azure-pipelines · 2025-02-17T10:13:41Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-17T11:01:03Z

src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.cs

 using Microsoft.Maui.Controls;
 using Microsoft.Maui.Controls.Handlers.Compatibility;
 using Microsoft.Maui.Controls.Handlers.Items;
+using Microsoft.Maui.Controls.Handlers.Items2;


The build is facing:

D:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\CollectionView\CollectionViewTests.cs(13,40): error CS0234: The type or namespace name 'Items2' does not exist in the namespace 'Microsoft.Maui.Controls.Handlers' (are you missing an assembly reference?) [D:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.20348.0] D:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\CollectionView\CollectionViewTests.cs(13,40): error CS0234: The type or namespace name 'Items2' does not exist in the namespace 'Microsoft.Maui.Controls.Handlers' (are you missing an assembly reference?) [D:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-windows10.0.19041.0] D:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\CollectionView\CollectionViewTests.cs(13,40): error CS0234: The type or namespace name 'Items2' does not exist in the namespace 'Microsoft.Maui.Controls.Handlers' (are you missing an assembly reference?) [D:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-android] 9023 Warning(s) 3 Error(s)

Due to Microsoft.Maui.Controls.Handlers.Items2 not being available for Android and Windows, a build error occurred. I have now added a condition to resolve it. Could you please check? @jsuarezruiz

jsuarezruiz · 2025-02-17T11:46:28Z

/azp run

azure-pipelines · 2025-02-17T11:46:49Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2025-02-19T14:36:09Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-18T08:48:21Z

/rebase

jsuarezruiz · 2025-03-18T08:51:00Z

/azp run

azure-pipelines · 2025-03-18T08:51:21Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

@Ahamed-Ali Could you rebase and fix the conflict? Thanks in advance.

Ahamed-Ali · 2025-03-26T10:32:49Z

Since the same changes in this PR were already merged into the main branch in LayoutSubViews by this #28225, I have kept only the test. @PureWeen / @rmarinho / @jsuarezruiz

jsuarezruiz · 2025-03-27T07:01:53Z

/azp run

azure-pipelines · 2025-03-27T07:02:14Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-27T07:02:35Z

src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt

 *REMOVED*override Microsoft.Maui.Controls.Handlers.Compatibility.FrameRenderer.SetNeedsLayout() -> void
 *REMOVED*override Microsoft.Maui.Controls.Handlers.Compatibility.FrameRenderer.MovedToWindow() -> void
-override Microsoft.Maui.Controls.Handlers.Compatibility.VisualElementRenderer<TElement>.MovedToWindow() -> void
+override Microsoft.Maui.Controls.Handlers.Compatibility.VisualElementRenderer<TElement>.MovedToWindow() -> void


Can revert this unnecessary change?

This is not a change. The same code is only appearing as a change in this PR. When I removed the unshipped code of my fix, this appeared in the PR, and I am unable to remove it. @jsuarezruiz

src/Controls/tests/DeviceTests/Elements/CollectionView/CollectionViewTests.iOS.cs

jsuarezruiz · 2025-04-08T08:09:24Z

/rebase

jsuarezruiz · 2025-04-08T08:10:08Z

/azp run

azure-pipelines · 2025-04-08T08:10:30Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

Could you fix the build errors?

C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\CollectionView\CollectionViewTests.iOS.cs(19,7): error CS0105: The using directive for 'Microsoft.Maui.Handlers' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-ios]
C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\CollectionView\CollectionViewTests.iOS.cs(19,7): error CS0105: The using directive for 'Microsoft.Maui.Handlers' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-maccatalyst]
    2 Error(s)

Ahamed-Ali · 2025-04-14T11:24:37Z

Could you fix the build errors?

C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\CollectionView\CollectionViewTests.iOS.cs(19,7): error CS0105: The using directive for 'Microsoft.Maui.Handlers' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-ios]
C:\a\_work\1\s\src\Controls\tests\DeviceTests\Elements\CollectionView\CollectionViewTests.iOS.cs(19,7): error CS0105: The using directive for 'Microsoft.Maui.Handlers' appeared previously in this namespace [C:\a\_work\1\s\src\Controls\tests\DeviceTests\Controls.DeviceTests.csproj::TargetFramework=net9.0-maccatalyst]
    2 Error(s)

The build errors occurred because the same namespace was used twice. I have now resolved the errors. @jsuarezruiz

jsuarezruiz · 2025-05-09T07:28:13Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-09T07:28:24Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-12T15:29:56Z

src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt

 *REMOVED*override Microsoft.Maui.Controls.Handlers.Compatibility.FrameRenderer.SetNeedsLayout() -> void
 *REMOVED*override Microsoft.Maui.Controls.Handlers.Compatibility.FrameRenderer.MovedToWindow() -> void
-override Microsoft.Maui.Controls.Handlers.Compatibility.VisualElementRenderer<TElement>.MovedToWindow() -> void
+override Microsoft.Maui.Controls.Handlers.Compatibility.VisualElementRenderer<TElement>.MovedToWindow() -> void


This change is no longer necessary, right?

This is not a change. The same code is only appearing as a change in this PR. When I removed the unshipped code of my fix, this appeared in the PR, and I am unable to remove it. @jsuarezruiz

jsuarezruiz · 2025-06-24T06:48:29Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-24T06:48:42Z

Azure Pipelines successfully started running 1 pipeline(s).

mattleibow · 2025-07-22T17:12:44Z

/rebase

…#27801) * Fixed the Border Rendering issues in CollectionViewHandler2 * Remove the unwanted namspace * Removed UI test and added the device test * Resolved the build errors * Registered the cv2 handler inside the test to avoid other test failures * Added a Assert.NotNull test * Resolved the conflicts

dotnet-policy-service bot added the community ✨ Community Contribution label Feb 14, 2025

dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 14, 2025

jsuarezruiz added platform/ios collectionview-cv2 labels Feb 17, 2025

jsuarezruiz suggested changes Feb 17, 2025

View reviewed changes

rmarinho added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Feb 17, 2025

Ahamed-Ali force-pushed the fix-27608 branch from ff1e74a to c607623 Compare March 7, 2025 06:36

Ahamed-Ali marked this pull request as ready for review March 18, 2025 04:49

Ahamed-Ali requested a review from a team as a code owner March 18, 2025 04:49

Ahamed-Ali requested review from jfversluis and jsuarezruiz March 18, 2025 04:49

github-actions bot force-pushed the fix-27608 branch from c607623 to 46a79bb Compare March 18, 2025 08:49

jsuarezruiz reviewed Mar 26, 2025

View reviewed changes

Ahamed-Ali force-pushed the fix-27608 branch from 46a79bb to 9310b89 Compare March 26, 2025 10:15

jsuarezruiz suggested changes Mar 27, 2025

View reviewed changes

jsuarezruiz suggested changes Apr 14, 2025

View reviewed changes

jsuarezruiz suggested changes May 12, 2025

View reviewed changes

Ahamed-Ali force-pushed the fix-27608 branch from 5eddf91 to b30eb81 Compare May 14, 2025 06:06

Ahamed-Ali force-pushed the fix-27608 branch from f8acc55 to d1ef300 Compare June 12, 2025 04:43

Ahamed-Ali added 7 commits July 22, 2025 17:13

Fixed the Border Rendering issues in CollectionViewHandler2

c6e32c9

Remove the unwanted namspace

9a00d41

Removed UI test and added the device test

c28174d

Resolved the build errors

143842b

Registered the cv2 handler inside the test to avoid other test failures

a3e272d

Added a Assert.NotNull test

ace61ac

Resolved the conflicts

2e16463

github-actions bot force-pushed the fix-27608 branch from d1ef300 to 2e16463 Compare July 22, 2025 17:13

mattleibow approved these changes Jul 22, 2025

View reviewed changes

PureWeen changed the base branch from main to inflight/current August 15, 2025 23:24

PureWeen merged commit 683bde3 into dotnet:inflight/current Aug 15, 2025
1 check passed

github-actions bot locked and limited conversation to collaborators Sep 15, 2025

Conversation

Ahamed-Ali commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause of the issue

Description of Change

Same Changes of PR merged into Main

Issues Fixed

Tested the behaviour in the following platforms

Screenshot

Polygon

RoundRectangle

Uh oh!

dotnet-policy-service bot commented Feb 14, 2025

Uh oh!

jsuarezruiz commented Feb 17, 2025

Uh oh!

azure-pipelines bot commented Feb 17, 2025

Uh oh!

jsuarezruiz commented Feb 17, 2025

Uh oh!

azure-pipelines bot commented Feb 17, 2025

Uh oh!

jsuarezruiz Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali Feb 17, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Feb 17, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Feb 17, 2025

Uh oh!

azure-pipelines bot commented Feb 19, 2025

Uh oh!

jsuarezruiz commented Mar 18, 2025

Uh oh!

jsuarezruiz commented Mar 18, 2025

Uh oh!

azure-pipelines bot commented Mar 18, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented Mar 26, 2025

Uh oh!

jsuarezruiz commented Mar 27, 2025

Uh oh!

azure-pipelines bot commented Mar 27, 2025

Uh oh!

jsuarezruiz Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jsuarezruiz commented Apr 8, 2025

Uh oh!

jsuarezruiz commented Apr 8, 2025

Uh oh!

azure-pipelines bot commented Apr 8, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented Apr 14, 2025

Uh oh!

jsuarezruiz commented May 9, 2025

Uh oh!

azure-pipelines bot commented May 9, 2025

Uh oh!

jsuarezruiz May 12, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali May 13, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jun 24, 2025

Uh oh!

Ahamed-Ali commented Feb 14, 2025 •

edited

Loading

jsuarezruiz commented Feb 17, 2025 •

edited by jfversluis

Loading