Skip to content

Fix for [Windows]ToolbarItem visibility until Page Disappearing #26915

Merged
PureWeen merged 10 commits intodotnet:mainfrom
SuthiYuvaraj:fix-23608
Feb 7, 2025
Merged

Fix for [Windows]ToolbarItem visibility until Page Disappearing #26915
PureWeen merged 10 commits intodotnet:mainfrom
SuthiYuvaraj:fix-23608

Conversation

@SuthiYuvaraj
Copy link
Contributor

Root Cause

When changing the Toolbar Item properties on Disappearing event , the Handler is removed in Toolbar as the items are updating on the disappearing event on windows platform

Description of Change

Handled the null possibility in OnToolbarItemPropertyChanged

Issues Fixed

Fixes #26803

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output Video

Before Issue Fix After Issue Fix
Before Fix video
Recording.2024-12-27.132438.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 2, 2025
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 2, 2025
@SuthiYuvaraj SuthiYuvaraj marked this pull request as ready for review January 6, 2025 03:49
@SuthiYuvaraj SuthiYuvaraj requested a review from a team as a code owner January 6, 2025 03:49
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz jsuarezruiz self-requested a review January 14, 2025 11:10
@PureWeen PureWeen merged commit c205c84 into dotnet:main Feb 7, 2025
104 checks passed
@PureWeen PureWeen added this to the .NET 9 SR4 milestone Feb 7, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-toolbar ToolBar community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Windows] Object Null Reference Exception thrown when dynamically changing ToolbarItem visibility until Page Disappearing

5 participants