Fix for [Windows]ToolbarItem visibility until Page Disappearing #26915
Merged
PureWeen merged 10 commits intodotnet:mainfrom Feb 7, 2025
Merged
Fix for [Windows]ToolbarItem visibility until Page Disappearing #26915PureWeen merged 10 commits intodotnet:mainfrom
PureWeen merged 10 commits intodotnet:mainfrom
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Jan 14, 2025
jsuarezruiz
suggested changes
Jan 14, 2025
jsuarezruiz
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
When changing the Toolbar Item properties on Disappearing event , the Handler is removed in Toolbar as the items are updating on the disappearing event on windows platform
Description of Change
Handled the null possibility in OnToolbarItemPropertyChanged
Issues Fixed
Fixes #26803
Tested the behaviour in the following platforms
Output Video
Recording.2024-12-27.132438.mp4