[Windows] Ensure images in buttons never scale up, only down#21463
Merged
[Windows] Ensure images in buttons never scale up, only down#21463
Conversation
dotnet-policy-service
bot
added
the
legacy-area-controls
jsuarezruiz
previously approved these changes
Mar 27, 2024
PureWeen
requested changes
Mar 27, 2024
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
Can you merge over TJ's tests into this PR and generate images for his same scenarios?
PureWeen
reviewed
Mar 27, 2024
Ensure source is set after image opened event is subscribed to
PureWeen
approved these changes
Mar 27, 2024
Eilon
removed
the
legacy-area-controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Ensure images in buttons never scale up, only down, by setting the max height of images to the source
BitmapImage(scaled by display density).Issues Fixed
CC: Windows version of #20953