Conversation
mattleibow
approved these changes
Mar 26, 2024
rmarinho
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
On Android, even you if you already know the size your children, you still need to call "measure" so it can update its internal bookkeeping. If the layout cycle was caused by the measure on the child being invalidated, then it's going to expect its
OnMeasurecall to happen. This is also important if for some reason the "Firstitem" size gets updated and reused cells need to be remeasured. Android requires you to call "measure" so it can update its MeasuredWidth and MeasuredHeight values to use during arrange.Issues Fixed
Fixes #7562