Skip to content

Still measure children if size is known on CV#21409

Merged
rmarinho merged 1 commit intomainfrom
fix_7562
Mar 26, 2024
Merged

Still measure children if size is known on CV#21409
rmarinho merged 1 commit intomainfrom
fix_7562

Conversation

@PureWeen
Copy link
Member

Description of Change

On Android, even you if you already know the size your children, you still need to call "measure" so it can update its internal bookkeeping. If the layout cycle was caused by the measure on the child being invalidated, then it's going to expect its OnMeasure call to happen. This is also important if for some reason the "Firstitem" size gets updated and reused cells need to be remeasured. Android requires you to call "measure" so it can update its MeasuredWidth and MeasuredHeight values to use during arrange.

Issues Fixed

Fixes #7562

@PureWeen PureWeen requested a review from a team as a code owner March 23, 2024 16:54
@jsuarezruiz jsuarezruiz added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Mar 25, 2024
@rmarinho rmarinho merged commit 8220208 into main Mar 26, 2024
@rmarinho rmarinho deleted the fix_7562 branch March 26, 2024 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MeasureFirstItem makes items disappear on Android

5 participants