[X] don't expand types to Extension for x:Static

[StephaneDelcroix]

Description of Change

if a type name exists with an Extension suffix, xaml rules require us to use that. But not for x:Static

Issues Fixed

• fixes x:Static in conjunction with XamlCompilation results in XFC0101 compile time error. #11833

[samhouts]

Do we know if this is a path that is commonly used? Is this going to break a bunch of people?

[StephaneDelcroix]

Do we know if this is a path that is commonly used? Is this going to break a bunch of people?

it's only affecting namespace with both MyClass and MyClassExtension defined. I believe this is safe and the modified behaviour is the expected one

[StephaneDelcroix]

this is a dupe pr. the dupe is #15903. pick a single one

[mattleibow]

@StephaneDelcroix this has been many coffee cycles since this was created... Do we still want/need this?

[StephaneDelcroix]

@StephaneDelcroix this has been many coffee cycles since this was created... Do we still want/need this?

y, but in net9

[mattleibow]

This PR has ABI breaks as you noted, however, even if we switch to a new TFM (net10) old libraries that use this type and are built with an older maui will still break. People would have to recompile.

One workaround we can do is use default interface members.

Unless... and you would be on the hook for this (not sure what the hook would be and/or if it is enforceable) you say that this type is not meant to be used by anyone outside of maui and doing so is them opting into breaks.

And then this needs that oh-so-common rebase.

[StephaneDelcroix]

I reviewed this again. the only risk of breaking change would be if a 3rd party provide a markup extension that invoke serviceproviderGetService(typeof(IXamlTypeResolver)) which is unlikely

[StephaneDelcroix]

no longer a breaking change

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[StephaneDelcroix]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

/rebase