Put a binary copy of mlaunch in macios-binaries instead of in Azure. Fixes #3316. #3877
Conversation
…ixes dotnet#3316. If the Xamarin build is enabled, then build mlaunch from source, otherwise get it from macios-binaries. Fixes dotnet#3316.
Commit list for xamarin/macios-binaries: * xamarin/macios-binaries@69a9088 Bump mlaunch to xamarin/maccore@4505cd6f02 (dotnet#8) Diff: xamarin/macios-binaries@e1e8bdf...69a9088
Build msbuild/ after tools/, so that mlaunch builds when building from source, since its build needs the MSBuild logic installed by msbuild/.
|
Executing in wrench here: https://wrench.internalx.com/Wrench/index.aspx?lane=macios-mac-binary-mlaunch |
Build failure
|
|
It failed because the bundled mlaunch doesn't support xcode9.3, which will be fixed with this: xamarin/macios-binaries#9 |
Build success
|
| @@ -1,5 +1,5 @@ | |||
| TOP=. | |||
| SUBDIRS=builds runtime fsharp src tools msbuild | |||
There was a problem hiding this comment.
Why is this change of position important?
There was a problem hiding this comment.
It's important when building mlaunch from source, because mlaunch is a Xamarin.Mac project, and it needs the Xamarin.Mac msbuild targets / assemblies, which means that we need to build the msbuild directory before we build mlaunch (which is built in tools/mlaunch).
|
Wrench build succeeded fine. |
4 participants
If the Xamarin build is enabled, then build mlaunch from source, otherwise get it from macios-binaries.
Fixes #3316.