Skip to content

[Accounts] Fix ACFacebookAudience.OnlyMe mapping in SetPermissions - #26133

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/cuddly-fortnight
Jul 17, 2026
Merged

[Accounts] Fix ACFacebookAudience.OnlyMe mapping in SetPermissions#26133
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/cuddly-fortnight

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

Summary

AccountStoreOptions.SetPermissions mapped ACFacebookAudience.OnlyMe to ACFacebookAudienceValue.Friends in its switch statement, so callers could never actually request the OnlyMe audience — it silently behaved like Friends.

This changes the ACFacebookAudience.OnlyMe case to use ACFacebookAudienceValue.OnlyMe (the field is defined in src/accounts.cs via [Field ("ACFacebookAudienceOnlyMe")]).

The change is minimal and surgical — a single line.

🤖 Pull request created by Copilot

The switch statement in AccountStoreOptions.SetPermissions mapped
ACFacebookAudience.OnlyMe to ACFacebookAudienceValue.Friends, so callers
could not request the OnlyMe audience. Map it to ACFacebookAudienceValue.OnlyMe.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@rolfbjarne
rolfbjarne marked this pull request as ready for review July 16, 2026 13:42
Copilot AI review requested due to automatic review settings July 16, 2026 13:42
@rolfbjarne
rolfbjarne enabled auto-merge (squash) July 16, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an incorrect mapping in AccountStoreOptions.SetPermissions where ACFacebookAudience.OnlyMe was previously (and silently) mapped to ACFacebookAudienceValue.Friends, preventing callers from requesting the “OnlyMe” audience.

Changes:

  • Correct ACFacebookAudience.OnlyMe to map to ACFacebookAudienceValue.OnlyMe in the audience switch inside SetPermissions.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3c1f804d59c332b03f0b68924146d2f0c440424e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

1 similar comment
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #3c1f804] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 203 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 19 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 3c1f804d59c332b03f0b68924146d2f0c440424e [PR build]

@rolfbjarne
rolfbjarne merged commit ba063c5 into main Jul 17, 2026
56 of 57 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/cuddly-fortnight branch July 17, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants