Skip to content

[assembly-preparer] Subclass AssemblyModifierStep in ListExportedSymbols. - #25942

Merged
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/assembly-preparer-listexportedsymbols
Jul 7, 2026
Merged

[assembly-preparer] Subclass AssemblyModifierStep in ListExportedSymbols.#25942
rolfbjarne merged 1 commit into
mainfrom
dev/rolf/assembly-preparer-listexportedsymbols

Conversation

@rolfbjarne

Copy link
Copy Markdown
Member

This makes it easier to keep track of which steps modified assemblies and which didn't.

…ols.

This makes it easier to keep track of which steps modified assemblies and which didn't.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne
rolfbjarne marked this pull request as ready for review July 7, 2026 08:59
Copilot AI review requested due to automatic review settings July 7, 2026 09:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ListExportedSymbols linker step (when ASSEMBLY_PREPARER is enabled) to derive from AssemblyModifierStep, aligning it with the assembly-preparer pattern where steps explicitly report whether they modified an assembly (and should therefore be persisted through the AppBundleRewriter).

Changes:

  • Switch ListExportedSymbols (assembly-preparer build) from ConfigurationAwareStep to AssemblyModifierStep.
  • Refactor assembly filtering logic into a shared HasSymbols (AssemblyDefinition assembly) helper used by both build modes.
  • Implement ModifyAssembly/ProcessType/ProcessMethod overrides so assembly modifications are tracked via boolean return values.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #66235e2] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 66235e2c6c83579dc9af9c147ad203f35f72074d [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #66235e2] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 66235e2c6c83579dc9af9c147ad203f35f72074d [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 66235e2c6c83579dc9af9c147ad203f35f72074d [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #66235e2] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 66235e2c6c83579dc9af9c147ad203f35f72074d [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #66235e2] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 199 tests passed 🎉

Tests counts

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 17 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 18 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 66235e2c6c83579dc9af9c147ad203f35f72074d [PR build]

@rolfbjarne
rolfbjarne merged commit 1aca093 into main Jul 7, 2026
57 checks passed
@rolfbjarne
rolfbjarne deleted the dev/rolf/assembly-preparer-listexportedsymbols branch July 7, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants