[assembly-preparer] Subclass AssemblyModifierStep in ListExportedSymbols. - #25942
Conversation
…ols. This makes it easier to keep track of which steps modified assemblies and which didn't. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
This PR updates the ListExportedSymbols linker step (when ASSEMBLY_PREPARER is enabled) to derive from AssemblyModifierStep, aligning it with the assembly-preparer pattern where steps explicitly report whether they modified an assembly (and should therefore be persisted through the AppBundleRewriter).
Changes:
- Switch
ListExportedSymbols(assembly-preparer build) fromConfigurationAwareSteptoAssemblyModifierStep. - Refactor assembly filtering logic into a shared
HasSymbols (AssemblyDefinition assembly)helper used by both build modes. - Implement
ModifyAssembly/ProcessType/ProcessMethodoverrides so assembly modifications are tracked via boolean return values.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #66235e2] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #66235e2] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #66235e2] Build passed (Build macOS tests) ✅Pipeline on Agent |
🚀 [CI Build #66235e2] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 199 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
This makes it easier to keep track of which steps modified assemblies and which didn't.