Skip to content

[runtime/msbuild] Clean up some unused code.#24409

Merged
rolfbjarne merged 2 commits intomainfrom
dev/rolf/cleanup
Dec 11, 2025
Merged

[runtime/msbuild] Clean up some unused code.#24409
rolfbjarne merged 2 commits intomainfrom
dev/rolf/cleanup

Conversation

@rolfbjarne
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused code related to watch apps and deprecated Xamarin.Mac launch functionality. It cleans up obsolete properties and methods from the MSBuild tasks and removes the unused launch.h header file from the runtime.

  • Removed unused launch.h header file containing deprecated Xamarin.Mac launch sequence documentation
  • Cleaned up unused MSBuild task properties (AssemblyName, Debug, DebugIPAddresses, IsWatchApp, IsWatchExtension, IsXPCService)
  • Removed obsolete methods related to watch app handling (SetAppTransportSecurity, watch-specific logic in CompileMac/CompileMobile)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
runtime/xamarin/launch.h Complete removal of obsolete header file documenting Xamarin.Mac launch sequence
msbuild/Xamarin.Shared/Xamarin.Shared.targets Removed unused parameters from CompileAppManifest task invocations
msbuild/Xamarin.MacDev.Tasks/Tasks/CompileAppManifest.cs Removed unused properties and methods, simplified watch app handling to always use non-watch platform names

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #d4b01f0] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #d4b01f0] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #d4b01f0] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d4b01f0] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d4b01f0] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d4b01f0] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d4b01f0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #d4b01f0] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #d4b01f0] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: d4b01f0ced4766fd6dac2a779ed9738a2952bf26 [PR build]

@rolfbjarne rolfbjarne disabled auto-merge December 11, 2025 11:36
@rolfbjarne rolfbjarne enabled auto-merge (squash) December 11, 2025 11:36
@rolfbjarne rolfbjarne merged commit 388f3be into main Dec 11, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants