[runtime/msbuild] Clean up some unused code.#24409
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes unused code related to watch apps and deprecated Xamarin.Mac launch functionality. It cleans up obsolete properties and methods from the MSBuild tasks and removes the unused launch.h header file from the runtime.
- Removed unused
launch.hheader file containing deprecated Xamarin.Mac launch sequence documentation - Cleaned up unused MSBuild task properties (AssemblyName, Debug, DebugIPAddresses, IsWatchApp, IsWatchExtension, IsXPCService)
- Removed obsolete methods related to watch app handling (SetAppTransportSecurity, watch-specific logic in CompileMac/CompileMobile)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| runtime/xamarin/launch.h | Complete removal of obsolete header file documenting Xamarin.Mac launch sequence |
| msbuild/Xamarin.Shared/Xamarin.Shared.targets | Removed unused parameters from CompileAppManifest task invocations |
| msbuild/Xamarin.MacDev.Tasks/Tasks/CompileAppManifest.cs | Removed unused properties and methods, simplified watch app handling to always use non-watch platform names |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #d4b01f0] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #d4b01f0] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #d4b01f0] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #d4b01f0] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #d4b01f0] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #d4b01f0] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #d4b01f0] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #d4b01f0] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #d4b01f0] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 119 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.