Skip to content

Conversation

@mandel-macaque
Copy link
Contributor

Based on the return type of a delegate we need to generate code to convert the native return type of the trampoline to that used by the managed delegate.

This new function takes the type info of the return type of the delegate and the name of the aux variable and generates the correct conversion.

Base automatically changed from dev/mandel/intptr-zero-check to main March 16, 2025 18:12
@github-actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

Based on the return type of a delegate we need to generate code to
convert the native return type of the trampoline to that used by the
managed delegate.

This new function takes the type info of the return type of the delegate
and the name of the aux variable and generates the correct conversion.
@mandel-macaque mandel-macaque force-pushed the dev/mandel/factory-trampoline-return branch from bc29920 to 092fd00 Compare March 16, 2025 18:32
@github-actions
Copy link
Contributor

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #ae0c443] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ae0c443] Build passed (Build packages) ✅

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #ae0c443] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ae0c443] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #092fd00] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 092fd00f6d51937f69a9acbd306c7b446e73562e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ae0c443] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #ae0c443] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build #ae0c443] Tests on macOS arm64 - Mac Sequoia (15) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #ae0c443] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 115 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ae0c443faa79831a38f507aee3e0a2fea5d4c4ca [PR build]

@mandel-macaque mandel-macaque merged commit 3bdeeda into main Mar 17, 2025
41 of 43 checks passed
@mandel-macaque mandel-macaque deleted the dev/mandel/factory-trampoline-return branch March 17, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants