[RGen] Implement the generation of the Notifications helper class. #22265

mandel-macaque · 2025-02-28T23:12:06Z

Implement the notifications helper class for those properties marked as notifications. Code supports the same configuration options as bgen and the test ensures that all configurations are tested:

No special config
Special args.
Special notification center.
Special args and notification center.

Add the missing notification configuration options for the FieldAttribute. Do remember that we will use the analyzer to make sure that those options are only used when the user passes the notification flag.

Implement the notifications helper class for those properties marked as noticicaitons. Code supports the same configuration options as bgen and the test ensures that all configurations are tested: 1. No special config 2. Special args. 3. Special noticication center. 4. Special args and noticication center.

github-actions · 2025-02-28T23:16:14Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-03-02T18:45:36Z

✅ [PR Build #6100b60] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T18:48:34Z

✅ [PR Build #6100b60] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T18:55:14Z

✅ [PR Build #6100b60] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T19:06:25Z

💻 [PR Build #6100b60] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T19:08:15Z

💻 [PR Build #6100b60] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T19:08:18Z

💻 [PR Build #6100b60] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T19:08:25Z

💻 [PR Build #6100b60] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T19:20:20Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T19:29:11Z

💻 [CI Build #6100b60] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

vs-mobiletools-engineering-service2 · 2025-03-02T20:08:02Z

🚀 [CI Build #6100b60] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 6100b606dd49033e914ec2b80aff0b9273b07eb0 [PR build]

mandel-macaque and others added 7 commits February 27, 2025 18:17

[RGen] Add missing configuraiton options for notifications.

83ddb1b

Add the missing notification configuration options for the FieldAttribute. Do remember that we will use the analyzer to make sure that those options are only used when the user passes the notification flag.

Auto-format source code

6a2c80f

Merge branch 'main' into dev/mandel/notification-options

94e4922

Fix the toString tests.

fab46e0

Merge branch 'main' into dev/mandel/notification-options

61aa4f6

Auto-format source code

b70b9f2

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Mar 1, 2025

View reviewed changes

Base automatically changed from dev/mandel/notification-options to main March 2, 2025 18:12

Merge branch 'main' into dev/mandel/generate-notification-helpers

6100b60

rolfbjarne approved these changes Mar 3, 2025

View reviewed changes

mandel-macaque merged commit 49763bb into main Mar 3, 2025
47 checks passed

mandel-macaque deleted the dev/mandel/generate-notification-helpers branch March 3, 2025 12:43

[RGen] Implement the generation of the Notifications helper class. #22265

[RGen] Implement the generation of the Notifications helper class. #22265

Uh oh!

Conversation

mandel-macaque commented Feb 28, 2025 • edited by rolfbjarne Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 2, 2025

✅ [PR Build #6100b60] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

✅ [PR Build #6100b60] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

✅ [PR Build #6100b60] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

💻 [PR Build #6100b60] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

💻 [PR Build #6100b60] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

💻 [PR Build #6100b60] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

💻 [PR Build #6100b60] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

💻 [CI Build #6100b60] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 2, 2025

🚀 [CI Build #6100b60] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mandel-macaque commented Feb 28, 2025 •

edited by rolfbjarne

Loading