[Rgen] Add logging to the transformer. #22016

mandel-macaque · 2025-01-20T13:12:39Z

No description provided.

Copilot

Copilot reviewed 5 out of 11 changed files in this pull request and generated 1 comment.

Files not reviewed (6)

src/rgen/Microsoft.Macios.Transformer/Microsoft.Macios.Transformer.csproj: Language not supported
src/rgen/Microsoft.Macios.Transformer/Transformer.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Transformer/Main.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Transformer/Workers/ClassTransformer.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Transformer/Workers/ProtocolTransformer.cs: Evaluated as low risk
src/rgen/Microsoft.Macios.Transformer/Workers/CopyTransformer.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/rgen/Microsoft.Macios.Transformer/Workers/StrongDictionaryTransformer.cs:25

The error message string contains an unnecessary colon at the end. It should be removed for clarity.

logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:", message.SymbolName, message.Path, destinationDirectory);

src/rgen/Microsoft.Macios.Transformer/Workers/ErrorDomainTransformer.cs:26

The error message string ends with a colon, which is unnecessary and could be confusing. It should be removed.

logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:",

Copilot · 2025-01-20T13:14:20Z

src/rgen/Microsoft.Macios.Transformer/Workers/SmartEnumTransformer.cs

 	public Task ConsumeAsync ((string Path, string SymbolName) message, Exception exception,
 		CancellationToken token = new CancellationToken ())
 	{
+		logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:", 


The colon at the end of the error message string is unnecessary and could be confusing. It should be removed.

Suggested change

logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:",

logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}",

github-actions · 2025-01-20T13:16:53Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-01-20T18:20:32Z

✅ [CI Build] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T18:30:12Z

✅ [CI Build] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T18:43:10Z

✅ [CI Build] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T19:00:53Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T19:01:44Z

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T19:02:21Z

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T19:03:10Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T19:03:16Z

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T19:08:56Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

❗ API diff vs stable (Breaking changes)

.NET ( ❗ Breaking changes ❗ )

iOS: vsdrops gist ( ❗ Breaking changes ❗ )
tvOS: vsdrops gist ( ❗ Breaking changes ❗ )
MacCatalyst: vsdrops gist ( ❗ Breaking changes ❗ )
macOS: vsdrops gist ( ❗ Breaking changes ❗ )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

vs-mobiletools-engineering-service2 · 2025-01-20T20:53:35Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 112 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 915d7cc4121cdef35ba9a64211f37165399fef09 [PR build]

[Rgen] Add logging to the transformer.

cef5001

mandel-macaque requested a review from Copilot January 20, 2025 13:12

Copilot AI reviewed Jan 20, 2025

View reviewed changes

Auto-format source code

5d6d4e4

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Jan 20, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 915d7cc into main Jan 20, 2025
41 of 43 checks passed

mandel-macaque deleted the dev/mandel/transformer-logging branch January 20, 2025 16:57

	logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}:",
	logger.Error (exception, "Error transforming {SymbolName} for path {Path} to {DestinationDirectory}",

[Rgen] Add logging to the transformer. #22016

[Rgen] Add logging to the transformer. #22016

Uh oh!

Conversation

mandel-macaque commented Jan 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 20, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 20, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

✅ [CI Build] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

✅ [CI Build] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

✅ [CI Build] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

💻 [CI Build] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 20, 2025

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants