Skip to content

[bgen] Accumulate BI1118 errors instead of bailing out on the first one. #21973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 4 commits into from
Jan 15, 2025
Merged

[bgen] Accumulate BI1118 errors instead of bailing out on the first one. #21973

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a4de0e
[bgen] Accumulate BI1118 errors instead of bailing out on the first one.
rolfbjarne Jan 13, 2025
41e2f0f
Merge remote-tracking branch 'origin/main' into dev/rolf/bgen-accumul…
rolfbjarne Jan 15, 2025
3c93be0
It's a warning, not an error.
rolfbjarne Jan 15, 2025
ad780cf
Don't throw if we only got warnings.
rolfbjarne Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/bgen/Generator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,6 +1536,7 @@ void ThrowIfExceptions ()
if (exceptions.All (v => v is BindingException pe && !pe.Error)) {
foreach (var e in exceptions)
ErrorHelper.Show (e);
return;
}

throw new AggregateException (exceptions);
Expand Down Expand Up @@ -3433,7 +3434,7 @@ void GenerateTypeLowering (MethodInfo mi, bool null_allowed_override, out String
void GenerateArgumentChecks (MethodInfo mi, bool null_allowed_override, PropertyInfo propInfo = null)
{
if (AttributeManager.IsNullable (mi))
ErrorHelper.Show (new BindingException (1118, false, mi));
exceptions.Add (ErrorHelper.CreateWarning (1118, mi));

foreach (var pi in mi.GetParameters ()) {
var safe_name = pi.Name.GetSafeParamName ();
Expand Down Expand Up @@ -4190,7 +4191,7 @@ void GenerateProperty (Type type, PropertyInfo pi, List<string> instance_fields_
var ba = GetBindAttribute (setter);
bool null_allowed = AttributeManager.IsNullable (setter);
if (null_allowed)
ErrorHelper.Show (new BindingException (1118, false, setter));
exceptions.Add (ErrorHelper.CreateWarning (1118, setter));
null_allowed |= AttributeManager.IsNullable (pi);
var not_implemented_attr = AttributeManager.GetCustomAttribute<NotImplementedAttribute> (setter);
string sel;
Expand Down
Loading