Skip to content

[tools] Ignore any interpreter settings when the current runtime isn't MonoVM. Fixes #20398. #21406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 2 commits into from
Oct 11, 2024
Merged

[tools] Ignore any interpreter settings when the current runtime isn't MonoVM. Fixes #20398. #21406

rolfbjarne merged 2 commits into from
Oct 11, 2024

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Oct 10, 2024

Tests that exercise this code path will be included in a different PR.

Fixes #20398.

@rolfbjarne
[tools] Ignore any interpreter settings when the current runtime isn'…
164055e 
…t MonoVM. Fixes #20398.

Tests that exercise this code path will be included in a different PR.

Fixes #20398.
@rolfbjarne
Merge remote-tracking branch 'origin/main' into issue-20398-interpret…
913170c 
…er-only-applicable-to-monovm
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 10, 2024

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 913170c4b0f0fa8bef6684d6f8d4b82d6dac35c3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 10, 2024

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 913170c4b0f0fa8bef6684d6f8d4b82d6dac35c3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 10, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 913170c4b0f0fa8bef6684d6f8d4b82d6dac35c3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 10, 2024

✅ API diff for current PR / commit

.NET (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 913170c4b0f0fa8bef6684d6f8d4b82d6dac35c3 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 10, 2024

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 913170c4b0f0fa8bef6684d6f8d4b82d6dac35c3 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Oct 11, 2024

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 101 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 913170c4b0f0fa8bef6684d6f8d4b82d6dac35c3 [PR build]

@rolfbjarne rolfbjarne merged commit 657f016 into main Oct 11, 2024
@rolfbjarne rolfbjarne deleted the dev/rolf/issue-20398-interpreter-only-applicable-to-monovm branch October 11, 2024 07:32
haritha-mohan pushed a commit that referenced this pull request Oct 19, 2024
@rolfbjarne @haritha-mohan
[tools] Ignore any interpreter settings when the current runtime isn'…
20b65ac 
…t MonoVM. Fixes #20398. (#21406)

Tests that exercise this code path will be included in a different PR.

Fixes #20398.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

+2 more reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@stephen-hawley stephen-hawley stephen-hawley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enabling the interpreter for macOS fails to build

5 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mandel-macaque @stephen-hawley