Skip to content

[release/8.0.1xx] [dotnet] Call the _CreateAssetPackManifest target during the build. Fixes #19669. #19714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Jan 3, 2024
Merged

[release/8.0.1xx] [dotnet] Call the _CreateAssetPackManifest target during the build. Fixes #19669. #19714

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
769d668
[dotnet] Call the _CreateAssetPackManifest target during the build. F…
rolfbjarne Dec 20, 2023
657bd2a
Don't call _CreateAssetPackManifest on macOS.
rolfbjarne Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@
_CopyResourcesToBundle;
_CompileCoreMLModels;
_CreatePkgInfo;
_CreateAssetPackManifestMobile;
_SmeltMetal;
_TemperMetal;
_DetectAppManifest;
Expand Down Expand Up @@ -273,6 +274,8 @@
</CreateAppBundleDependsOn>
</PropertyGroup>

<Target Name="_CreateAssetPackManifestMobile" Condition="'$(_PlatformName)' != 'macOS'" DependsOnTargets="_CreateAssetPackManifest" />

<!-- PublishTrimmed must be calculated as part of a target because IsMacEnabled on Windows will be set after connecting to the Mac -->
<Target Name="_ComputePublishTrimmed">
<PropertyGroup>
Expand Down