[MediaAccessibility] Add xcode 15 beta 7 support.#19016
Conversation
| bool CanProcess (Surface surface); | ||
|
|
||
| [Export ("processSurface:outSurface:timestamp:options:")] | ||
| MAFlashingLightsProcessorResult Process (Surface inSurface, Surface outSurface, double timestamp, [NullAllowed] NSDictionary<NSString, NSObject> options); |
There was a problem hiding this comment.
Can the options be a strong dictionary?
There was a problem hiding this comment.
I did not find any documentation about the keys or values. https://developer.apple.com/documentation/mediaaccessibility/maflashinglightsprocessoroptionkey?language=objc
Or in the header: https://github.com/xamarin/xamarin-macios/wiki/MediaAccessibility-iOS-xcode15.0-b1
There was a problem hiding this comment.
FYI - I also looked at the Swift doc'n and the key, oddly enough, is not an NSString, which is an inner struct called MAFlashingLightsProcessor.OptionKey which has initializers from String - it feels like they're keeping their options open for the future, but the values of the options are also untyped there and undocumented.
There was a problem hiding this comment.
I did notice the same, we should leave it as open as possible.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Alex Soto <[email protected]>
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
|
🔥 Failed to compare API and create generator diff 🔥 Failed to run apidiff Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 238 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
6 participants
No description provided.