Fix sending MidiPacket when MidiPacket has been created using a point… #18981

jamesdlow · 2023-09-09T11:31:18Z

Fix sending MidiPacket when MidiPacket has been created using a pointer to a byte[] rather than a byte[] passed as a reference.
MidiPacket.bytes is intiailized to a Array.Empty so it is never null, and so packet.BytePointer is never used.
We therefore need to check for ByteArray.Length being 0.
Midipacket.bytes is never 0 when intiailized to a 0 length byte[] as that constructor checked for 0 length byte[]

…er to a byte[] rather than a byte[] passed as a reference. MidiPacket.bytes is intiailized to a Array.Empty<byte> so it is never null, and so packet.BytePointer is never used. We therefore need to check for ByteArray.Length being 0. Midipacket.bytes is never 0 when intiailized to a 0 length byte[] as that constructor checked for 0 length byte[]

rolfbjarne · 2023-09-11T07:43:26Z

/azp run

azure-pipelines · 2023-09-11T07:43:46Z

Azure Pipelines successfully started running 1 pipeline(s).

rolfbjarne · 2023-09-11T09:12:19Z

@jamesdlow would you be able to create a self-contained test case for this (not using managed-midi)?

dalexsoto · 2023-09-14T00:17:58Z

/azp run

azure-pipelines · 2023-09-14T00:18:19Z

Azure Pipelines successfully started running 1 pipeline(s).

mandel-macaque · 2023-09-18T09:38:16Z

@jamesdlow @rolfbjarne I have requested a rerun for the failing test.

rolfbjarne · 2023-09-18T11:45:59Z

Marking as do-not-merge until we have tests, since this particular piece of code has regressed multiple times already.

github-actions · 2023-12-22T15:25:24Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

jamesdlow · 2023-12-22T23:26:32Z

@microsoft-github-policy-service agree

rolfbjarne · 2024-01-02T10:51:49Z

/azp run

azure-pipelines · 2024-01-02T10:52:09Z

Azure Pipelines successfully started running 1 pipeline(s).

vs-mobiletools-engineering-service2 · 2024-01-02T12:37:45Z

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T12:39:10Z

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T13:09:53Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

~~iOS~~ (no change detected)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
~~macOS~~ (no change detected)

NET (empty diffs)

~~iOS~~: (empty diff detected)
~~tvOS~~: (empty diff detected)
~~MacCatalyst~~: (empty diff detected)
~~macOS~~: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 07191dfb688d6b3f9de324002661f0b353a65e03 [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T13:24:41Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T13:25:56Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 07191dfb688d6b3f9de324002661f0b353a65e03 [PR build]

vs-mobiletools-engineering-service2 · 2024-01-02T15:53:41Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 07191dfb688d6b3f9de324002661f0b353a65e03 [PR build]

rolfbjarne · 2024-01-02T18:40:58Z

/sudo backport release/8.0.1xx

vs-mobiletools-engineering-service2 · 2024-01-02T18:41:28Z

Backport Job to branch release/8.0.1xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2024-01-02T18:43:05Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8863717 for more details.

…ated using a point. (#19716) Fix sending MidiPacket when MidiPacket has been created using a pointer to a byte[] rather than a byte[] passed as a reference. MidiPacket.bytes is intiailized to a Array.Empty<byte> so it is never null, and so packet.BytePointer is never used. We therefore need to check for ByteArray.Length being 0. Midipacket.bytes is never 0 when intiailized to a 0 length byte[] as that constructor checked for 0 length byte[] Backport of #18981 --------- Co-authored-by: James Low <[email protected]>

jamesdlow mentioned this pull request Sep 9, 2023

"start_index + length > array length" with sample code atsushieno/managed-midi#76

Open

rolfbjarne added the community Community contribution ❤ label Sep 11, 2023

This comment has been minimized.

Sign in to view

Merge branch 'main' into midipacket-pointerfix

a8e67c2

This comment has been minimized.

Sign in to view

mandel-macaque approved these changes Sep 18, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added the do-not-merge Do not merge this pull request label Sep 18, 2023

rolfbjarne and others added 3 commits December 22, 2023 12:24

Merge remote-tracking branch 'origin/main' into midipacket-pointerfix

dfcab4c

Create better fix + add test.

2871ccb

Auto-format source code

07191df

rolfbjarne removed the do-not-merge Do not merge this pull request label Dec 22, 2023

rolfbjarne approved these changes Jan 2, 2024

View reviewed changes

rolfbjarne requested a review from mandel-macaque January 2, 2024 17:17

dalexsoto approved these changes Jan 2, 2024

View reviewed changes

rolfbjarne merged commit d9e5206 into dotnet:main Jan 2, 2024

vs-mobiletools-engineering-service2 mentioned this pull request Jan 2, 2024

[release/8.0.1xx] Fix sending MidiPacket when MidiPacket has been created using a point. #19716

Merged

Fix sending MidiPacket when MidiPacket has been created using a point… #18981

Fix sending MidiPacket when MidiPacket has been created using a point… #18981

Uh oh!

Conversation

jamesdlow commented Sep 9, 2023

Uh oh!

rolfbjarne commented Sep 11, 2023

Uh oh!

azure-pipelines bot commented Sep 11, 2023

Uh oh!

rolfbjarne commented Sep 11, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto commented Sep 14, 2023

Uh oh!

azure-pipelines bot commented Sep 14, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Sep 18, 2023

Uh oh!

This comment has been minimized.

rolfbjarne commented Sep 18, 2023

Uh oh!

github-actions bot commented Dec 22, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

jamesdlow commented Dec 22, 2023

Uh oh!

rolfbjarne commented Jan 2, 2024

Uh oh!

azure-pipelines bot commented Jan 2, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

rolfbjarne commented Jan 2, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants