Skip to content

[dotnet] Pass path to native swift libraries when linking NativeAOT apps for macOS.#18894

Merged
rolfbjarne merged 1 commit intodotnet:net8.0from
rolfbjarne:nativeaot-needs-swift-on-macos
Sep 1, 2023
Merged

[dotnet] Pass path to native swift libraries when linking NativeAOT apps for macOS.#18894
rolfbjarne merged 1 commit intodotnet:net8.0from
rolfbjarne:nativeaot-needs-swift-on-macos

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

@rolfbjarne rolfbjarne commented Aug 31, 2023

Fixes this linker failure when compiling monotouch-test:

clang: error: linker command failed with exit code 1 (use -v to see invocation)
    Errors
        xamarin-macios/builds/downloads/dotnet-sdk-8.0.100-rc.2.23428.11/packs/Microsoft.macOS.Sdk/13.3.8852-net8-rc2/targets/Xamarin.Shared.Sdk.targets(1527,3): clang++ exited with code 1:
ld: library not found for -lswiftCore
clang: error: linker command failed with exit code 1 (use -v to see invocation) [/Users/rolf/work/maccore/net8.0/xamarin-macios/tests/dotnet/MySimpleApp/macOS/MySimpleApp.csproj]

@rolfbjarne
[dotnet] Pass path to native swift libraries when linking NativeAOT a…
2b1e013 
…pps for macOS.

Fixes this linker failure when compiling monotouch-test:

    clang: error: linker command failed with exit code 1 (use -v to see invocation)
        Errors
            xamarin-macios/builds/downloads/dotnet-sdk-8.0.100-rc.2.23428.11/packs/Microsoft.macOS.Sdk/13.3.8852-net8-rc2/targets/Xamarin.Shared.Sdk.targets(1527,3): clang++ exited with code 1:
    ld: library not found for -lswiftCore
    clang: error: linker command failed with exit code 1 (use -v to see invocation) [/Users/rolf/work/maccore/net8.0/xamarin-macios/tests/dotnet/MySimpleApp/macOS/MySimpleApp.csproj]
@rolfbjarne
Copy link
Copy Markdown
Member Author

rolfbjarne commented Aug 31, 2023

CC @filipnavara

@filipnavara
Copy link
Copy Markdown
Member

filipnavara commented Aug 31, 2023 •
edited
Loading

Yeah, this was missed between the NativeAOT linker switch PR and the NativeAOT/macOS PR that landed later. Thanks for fixing it.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Aug 31, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Aug 31, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Aug 31, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Aug 31, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 2b1e0136e4d3bf9b798dba7672a6f9c6aee260ab [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Aug 31, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 2b1e0136e4d3bf9b798dba7672a6f9c6aee260ab [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

vs-mobiletools-engineering-service2 commented Aug 31, 2023

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 4 tests failed, 229 tests passed.

Failures

❌ bcl tests

1 tests failed, 68 tests passed.
Details
  • [NUnit] Mono CorlibTests/watchOS 32-bits - simulator/Debug: Failed

Html Report (VSDrops) Download

❌ dotnettests tests

1 tests failed, 0 tests passed.
Details
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

❌ xammac tests

2 tests failed, 1 tests passed.
Details
  • xammac tests/Mac Modern/Release: Failed (Test run failed.
    Tests run: 2843 Passed: 2748 Inconclusive: 8 Failed: 1 Ignored: 94)
  • xammac tests/Mac Modern/Release (all optimizations): Failed (Test run failed.
    Tests run: 2843 Passed: 2749 Inconclusive: 8 Failed: 2 Ignored: 92)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 2b1e0136e4d3bf9b798dba7672a6f9c6aee260ab [PR build]

@rolfbjarne
Copy link
Copy Markdown
Member Author

rolfbjarne commented Sep 1, 2023

Test failures are unrelated:

@rolfbjarne rolfbjarne merged commit 4f26004 into dotnet:net8.0 Sep 1, 2023
@rolfbjarne rolfbjarne deleted the nativeaot-needs-swift-on-macos branch September 1, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@filipnavara filipnavara filipnavara approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rolfbjarne @filipnavara @vs-mobiletools-engineering-service2 @mandel-macaque