[CoreData] Add support for xcode 15 beta6. by mandel-macaque · Pull Request #18837 · dotnet/macios

mandel-macaque · 2023-08-26T20:36:58Z

No description provided.

github-actions · 2023-08-26T20:41:21Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

tj-devel709 · 2023-08-28T15:46:36Z

 		Transformable = 1800,
-		ObjectID = 2000
+		ObjectID = 2000,
+		[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0), MacCatalyst (17, 0)]


Why use the old versions here? Specifically the Watch, TV, Mac, and iOS

https://developer.apple.com/documentation/coredata/nsattributetype/compositeattributetype?changes=__6

due to a yy.

tj-devel709 · 2023-08-28T15:49:50Z

+		[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0)]
+		[Export ("finishDeferredLightweightMigration:")]
+		bool FinishDeferredLightweightMigration ([NullAllowed] out NSError error);
+
+		[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0)]
+		[Export ("finishDeferredLightweightMigrationTask:")]
+		bool FinishDeferredLightweightMigrationTask ([NullAllowed] out NSError error);


These are old versions too but looks like they may actually be older? Just checking

This ones are correct. We probably forgot them in one of the . release.

tj-devel709

Other than the version check, lgtm

github-actions · 2023-08-28T22:02:20Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2023-08-28T23:27:22Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: fd8985ed9f81929b1cbafdbae2ddd7bff0aa652a [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T23:36:34Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T23:36:36Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T23:38:10Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-28T23:54:32Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: fd8985ed9f81929b1cbafdbae2ddd7bff0aa652a [PR build]

vs-mobiletools-engineering-service2 · 2023-08-29T20:51:39Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: fd8985ed9f81929b1cbafdbae2ddd7bff0aa652a [PR build]

mandel-macaque and others added 2 commits August 26, 2023 16:35

[CoreData] Add support for xcode 15 berta6.

5fd8ea4

Auto-format source code

468393d

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Aug 28, 2023

View reviewed changes

rolfbjarne changed the title ~~[CoreData] Add support for xcode 15 berta6.~~ [CoreData] Add support for xcode 15 beta6. Aug 28, 2023

rolfbjarne approved these changes Aug 28, 2023

View reviewed changes

tj-devel709 reviewed Aug 28, 2023

View reviewed changes

mandel-macaque and others added 4 commits August 28, 2023 17:40

Fix missing attr.

9e1e614

Address reviews.

210bdb1

Merge branch 'net8.0-xcode15' into net8.0-xcode15-coredata

5e6fb29

Auto-format source code

fd8985e

haritha-mohan approved these changes Aug 28, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 0e4afa6 into dotnet:net8.0-xcode15 Aug 30, 2023

mandel-macaque deleted the net8.0-xcode15-coredata branch August 30, 2023 13:42

Conversation

mandel-macaque commented Aug 26, 2023

Uh oh!

github-actions Bot commented Aug 26, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

tj-devel709 Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

tj-devel709 Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Aug 28, 2023

Choose a reason for hiding this comment

Uh oh!

tj-devel709 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 28, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 28, 2023

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 29, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tj-devel709 Aug 28, 2023 •

edited

Loading