[xcode15] Add support for Xcode 15 and corresponding OS versions. by mandel-macaque · Pull Request #18641 · dotnet/macios

mandel-macaque · 2023-08-05T01:21:09Z

No description provided.

Fixes this warning: > clang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument]

…by bumping the min watchOS version.

…bindings. The classes have been completely removed, both from the headers and Apple's documentation, so assume they want it gone and remove it ourselves as well.

The NewsstandKit framework has been completely removed, both from the headers and Apple's documentation, so assume they want it gone and remove it ourselves as well.

Xcode15 added a new liner, ld_prime which has a number of bugs up to xcode 15 beta4. We can fix this by fwd the ld64 flag to the linker which allows to use the OLD ld64 linker over ld_primer until we have a fix from apple. Refereces: Apple docs: https://developer.apple.com/forums/thread/715385 Bug: https://developer.apple.com/forums/thread/733317

…longer supported.

…valid value.

rolfbjarne · 2023-08-07T16:46:07Z

 		public void SimpleValuesSet ()
 		{
+			if (TestRuntime.CheckXcodeVersion (15, 0))
+				Assert.Ignore ("Test timeouts on Xcode 15 beta 4.");


Do we have an issue to verify this later?

I'll add an issue and will link it to the master xcode15 issue

rolfbjarne · 2023-08-07T17:12:15Z

 				// Work around https://github.com/dotnet/msbuild/issues/8845
 				args.Add ("/v:diag");
 				args.Add ("/consoleloggerparameters:Verbosity=Quiet");
+				args.Add ("/consoleloggerparameters:Verbosity=Quiet");


Do we need this argument twice?

I bet is a too fast yy.

github-actions · 2023-08-07T21:20:55Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

dalexsoto · 2023-08-07T21:46:07Z

Ref: #18556

vs-mobiletools-engineering-service2 · 2023-08-07T23:07:39Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: feb500bdcc4f58fdfd350fe4989767e477d7898e [PR build]

vs-mobiletools-engineering-service2 · 2023-08-07T23:16:21Z

🔥 Failed to compare API and create generator diff 🔥

Failed to update apidiff references

Pipeline on Agent
Hash: feb500bdcc4f58fdfd350fe4989767e477d7898e [PR build]

haritha-mohan · 2023-08-07T22:24:33Z

 #if __IOS__ && !__MACCATALYST__
 	public partial class NSUrlConnection {
 		// Extension from iOS5, NewsstandKit
+		[EditorBrowsable (EditorBrowsableState.Never)]


this is me just being picky but why not just make all obsolete marked selectors not editor browsable? are there special cases when we would still want this obs selector visible via intellisense?

There are some of them that are Obsoleted but not removed, that is, they are a warning that in the future they'll be removed. Others, like this ones, are obsoleted and removed by apple and so we want to make sure that users don't even know about them.

haritha-mohan · 2023-08-07T22:48:53Z

 				};
 				AppDelegate.PresentModalViewController (nc, 0.5);
-				if (TestRuntime.CheckXcodeVersion (14, 0)) {
+				if (TestRuntime.CheckXcodeVersion (15, 0)) {


why is the explicit check for Xcode 15 necessary? wasn't the prev logic checking for the same?

Look at the content of the if block ;)

vs-mobiletools-engineering-service2 · 2023-08-07T23:22:42Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-07T23:24:15Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-07T23:29:22Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-08-08T06:38:41Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: feb500bdcc4f58fdfd350fe4989767e477d7898e [PR build]

rolfbjarne and others added 30 commits August 4, 2023 11:47

Bump to Xcode 15 and the corresponding OS version.

847763a

[runtime] Don't pass -stdlib=libc++ to clang anymore.

a1163cc

Fixes this warning: > clang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument]

[build] Add support for skipping 32-bit watchOS device architectures …

3beafbb

…by bumping the min watchOS version.

[devops] Use the beta Xcode channel.

3e39cf4

[PassKit] Remove the PKDisbursementAuthorizationController[Delegate] …

440dd86

…bindings. The classes have been completely removed, both from the headers and Apple's documentation, so assume they want it gone and remove it ourselves as well.

[NewsstandKit] Remove this framework.

e082cf1

The NewsstandKit framework has been completely removed, both from the headers and Apple's documentation, so assume they want it gone and remove it ourselves as well.

[mlaunch] Bump to a version that works with Xcode 15.

9ee6796

Bump SdkVersions.cs

e30e247

Adjust path to Xcode to match the provisionator.

35a4615

[devops] Provision simulators before the build.

f27b190

[xcode15] Bump to use beta2

bd4756c

[CoreImage] Fix CIPhotoEffectProtocol compilation issue

67a3455

[system-dependencies] Fix installing the simulator runtimes.

61a3921

Bump to beta 3

3cb9986

[introspection] Fix tests

77744b0

[xcode15] Bump to Xcode 15 beta 4

b2c4fd4

[Tests] Fix cecil tests.

67ab5a5

[Xtro] Update ginore/todo files for Xcode 15.

9c9a2be

[Mtouch] Add the default needed flags for mtouch.

c25f6fc

[Introspection] Fix a number of failing tests.

b8b56bf

Auto-format source code

41c370e

[Mtouch] Ignore warning about duplicated libs.

d5c6d22

[Mtouch] Remove tests for removed arch.

b0e4466

[Introspection] Fix failing tests.

576cebc

[WatchOS] Fix tests and code to adapt to the fact that armv7k is not …

44b2342

…longer supported.

[Linker] Fix regression tests for xcode 15.

558e45f

[Dotnet] Fix tests that have ios/tvos hardcoded.

1370e84

[Mtouch] Fix typo in linker flag.

f3be00d

Bump Xharness to dotnet/xharness@915e9ec

7e4507b

This comment has been minimized.

Sign in to view

mandel-macaque added 2 commits August 5, 2023 15:21

[Foundation] CountryCode was deprecated and does not longer return a …

c22d390

…valid value.

[Windows] Move the correct Build.props to the sources dir.

59674cb

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Aug 7, 2023

View reviewed changes

mandel-macaque and others added 4 commits August 7, 2023 16:12

[CI] Use xcode to install the simulators in EO machines.

8c4ce01

[Tests] Ignore test until net7 is released with a fix.

93ea6f9

Yaml

c3bb685

Auto-format source code

d1106a2

Address reviews. Add issue and remove duplicated param.

feb500b

dalexsoto approved these changes Aug 7, 2023

View reviewed changes

haritha-mohan approved these changes Aug 7, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

mandel-macaque merged commit 8691e43 into dotnet:net8.0-xcode15 Aug 8, 2023

mandel-macaque deleted the net8.0-xcode15 branch August 8, 2023 14:28

Conversation

mandel-macaque commented Aug 5, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 7, 2023

⚠️ Your code has been reformatted. ⚠️

Uh oh!

dalexsoto commented Aug 7, 2023

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 7, 2023

💻 [CI Build] Windows Integration Tests passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 7, 2023

Uh oh!

haritha-mohan Aug 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

haritha-mohan Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Aug 8, 2023

Choose a reason for hiding this comment

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 7, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 7, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Aug 7, 2023

📚 [PR Build] Artifacts 📚

Packages generated

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Aug 8, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

haritha-mohan Aug 7, 2023 •

edited

Loading