Skip to content

[msbuild] Copy the zip file back to Windows from the Zip task for remote builds. Fixes #18402.#18447

Merged
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:msbuild-copy-zips-to-windows
Jun 15, 2023
Merged

[msbuild] Copy the zip file back to Windows from the Zip task for remote builds. Fixes #18402.#18447
rolfbjarne merged 1 commit intodotnet:mainfrom
rolfbjarne:msbuild-copy-zips-to-windows

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Jun 14, 2023

The zip file might be used later directly on Windows (for instance it might be
embedded inside a binding assembly as an embedded resource), so make sure to
copy it back to Windows.

Fixes #18402 part 2.

@rolfbjarne
[msbuild] Copy the zip file back to Windows from the Zip task for rem…
8a46a16 
…ote builds. Fixes dotnet#18402.

The zip file might be used later directly on Windows (for instance it might be
embedded inside a binding assembly as an embedded resource), so make sure to
copy it back to Windows.

Fixes dotnet#18402 part 2.
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners June 14, 2023 20:56
@rolfbjarne rolfbjarne mentioned this pull request Jun 7, 2023
Closed
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 14, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 14, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 8a46a167922583f761fbb6ff9f0bb12ff536f94f [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 14, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 14, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 14, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 8a46a167922583f761fbb6ff9f0bb12ff536f94f [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 15, 2023

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 35 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 8a46a167922583f761fbb6ff9f0bb12ff536f94f [PR build]

@rolfbjarne rolfbjarne merged commit 4c51cfa into dotnet:main Jun 15, 2023
@rolfbjarne rolfbjarne deleted the msbuild-copy-zips-to-windows branch June 15, 2023 14:32
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Jun 15, 2023

/sudo backport release/7.0.2xx-xcode14.3

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 15, 2023

Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Jun 15, 2023

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7923362 for more details.

rolfbjarne added a commit that referenced this pull request Jun 16, 2023
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/7.0.2xx-xcode14.3] [msbuild] Copy the zip file back to Windo…
8606b32 
…ws from the Zip task for remote builds. Fixes #18402. (#18454)

The zip file might be used later directly on Windows (for instance it
might be embedded inside a binding assembly as an embedded resource), so make
sure to copy it back to Windows.

Fixes #18402 part 2.

Backport of #18447

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@rolfbjarne rolfbjarne mentioned this pull request Jan 26, 2024
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@mauroa mauroa mauroa approved these changes

@emaf emaf emaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to build iOS (.NET 7) Binding Library wrapping iOS Framework Native Reference?

5 participants

@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @mauroa @emaf