Skip to content

[dotnet] integrate writing out class map into static registrar #18141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephen-hawley merged 2 commits into from
Apr 26, 2023
Merged

[dotnet] integrate writing out class map into static registrar #18141

stephen-hawley merged 2 commits into from
Apr 26, 2023

Conversation

@stephen-hawley
Copy link
Contributor

@stephen-hawley stephen-hawley commented Apr 25, 2023

Replaced the existing type map in StaticRegistrar.cs with a CSToObjCMap.
Added code to write it out to a specified path as XML.
Currently the path is a parameter that defaults to null and is not (yet) used.

@stephen-hawley stephen-hawley added not-notes-worthy Ignore for release notes dotnet An issue or pull request related to .NET (6) labels Apr 25, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 25, 2023

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: bda461f1f150d45e4b9f893d2fde717d0e603aea [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 25, 2023

❌ [PR Build] Tests on macOS M1 - Mac Ventura (13.0) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 25, 2023

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1030.Ventura
Hash: bda461f1f150d45e4b9f893d2fde717d0e603aea [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 25, 2023

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 25, 2023

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: bda461f1f150d45e4b9f893d2fde717d0e603aea [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

vs-mobiletools-engineering-service2 commented Apr 26, 2023

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 3 tests failed, 222 tests passed.

Failures

❌ linker tests

2 tests failed, 63 tests passed.
Details
  • trimmode link/Mac Catalyst [dotnet]/Debug [dotnet]: BuildFailure (Harness exception for 'trimmode link': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/4/s/xamarin-macios/tests/bindings-test/dotnet/MacCatalyst (TimedOut: True ExitCode: 0):
    Running git ls-files
    Makefile
    bindings-test.csproj
    Process 51300 didn't exit within 00:01:00 and will be killed
    Killing process tree of 51300...
    Pids to kill: 51300
    Running lldb diagnostics for pid 51300
    Printing backtrace for pid=51300
    (lldb) command source -s 0 '/var/folders/v6/yn10rhw51mj14vh6_tk58_gc0000gn/T/tmp29a03cc.tmp'
    Executing commands in '/var/folders/v6/yn10rhw51mj14vh6_tk58_gc0000gn/T/tmp29a03cc.tmp'.
    (lldb) process attach --pid 51300
    error: attach failed: no such process.
    51300 Execution timed out after 60 seconds and the process was killed.
    Process git exited with 0
    at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/TestProject.cs:103
    at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/TestProject.cs:208
    at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )
  • trimmode link/Mac Catalyst [dotnet]/Release [dotnet]: BuildFailure (Harness exception for 'trimmode link': System.Exception: Failed to list the files in the directory /Users/builder/azdo/_work/4/s/xamarin-macios/tests/bindings-test/dotnet/MacCatalyst (TimedOut: True ExitCode: 0):
    Running git ls-files
    Makefile
    bindings-test.csproj
    Process 51309 didn't exit within 00:01:00 and will be killed
    Killing process tree of 51309...
    Pids to kill: 51309
    Running lldb diagnostics for pid 51309
    Printing backtrace for pid=51309
    (lldb) command source -s 0 '/var/folders/v6/yn10rhw51mj14vh6_tk58_gc0000gn/T/tmp56abdf4.tmp'
    Executing commands in '/var/folders/v6/yn10rhw51mj14vh6_tk58_gc0000gn/T/tmp56abdf4.tmp'.
    (lldb) process attach --pid 51309
    error: attach failed: no such process.
    51309 Execution timed out after 60 seconds and the process was killed.
    Process git exited with 0
    at Xharness.TestProject.ListFilesAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, System.String test_dir, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager) [0x00218] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/TestProject.cs:103
    at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x00340] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/TestProject.cs:167 at Xharness.TestProject.CreateCopyAsync (Microsoft.DotNet.XHarness.Common.Logging.ILog log, Microsoft.DotNet.XHarness.Common.Execution.IProcessManager processManager, Xharness.Jenkins.TestTasks.ITestTask test, System.String rootDirectory, System.Collections.Generic.Dictionary2[TKey,TValue] allProjectReferences) [0x0078b] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/TestProject.cs:208
    at Xharness.Jenkins.TestTasks.TestTasks.RunInternalAsync () [0x00117] in /Users/builder/azdo/_work/4/s/xamarin-macios/tests/xharness/Jenkins/TestTasks/TestTask.cs:260 )

Html Report (VSDrops) Download

❌ monotouch tests

1 tests failed, 24 tests passed.
Details
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): TimedOut

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: bda461f1f150d45e4b9f893d2fde717d0e603aea [PR build]

mandel-macaque
mandel-macaque suggested changes Apr 26, 2023
View reviewed changes
tools/common/CSToObjCMap.cs
@@ -1,5 +1,6 @@
using System;
using System.Collections.Generic;
using System.Linq;
Copy link
Contributor

@mandel-macaque mandel-macaque Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this added? Either this code was not compiling when it landed, or the using is not needed. There are no others changes in the file but the inclusion of the System.Linq, that is a little fishy.

Copy link
Contributor Author

@stephen-hawley stephen-hawley Apr 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity - the need for this using was created because the file was originally part of a project with global usings which breaks when put into a project without them. It was causing mmp to fail to compile.

@stephen-hawley stephen-hawley merged commit 935ec25 into dotnet:main Apr 26, 2023
@stephen-hawley stephen-hawley deleted the registrar-extension branch April 26, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

+1 more reviewer

@mandel-macaque mandel-macaque mandel-macaque requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dotnet An issue or pull request related to .NET (6) not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stephen-hawley @vs-mobiletools-engineering-service2 @rolfbjarne @mandel-macaque