-
Notifications
You must be signed in to change notification settings - Fork 555
[Foundation] Preserve all members of WrappedNSInputStream. Fixes #15860. #18011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…et#15860. Preserve all members of WrappedNSInputStream, and mark it as a non-direct binding class, so that the linker doesn't trim away any virtual overrides, since they're actually necessary. Fixes dotnet#15860.
|
this looks like it is backport worthy to the xcode14.3 branches |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
/sudo backport release/xcode14.3 |
|
/sudo backport xcode14.3 |
|
/sudo backport release/6.0.4xx-xcode14.3 |
|
Backport Job to branch release/xcode14.3 Created! The magic is happening here |
|
Backport Job to branch xcode14.3 Created! The magic is happening here |
|
Backport Job to branch release/6.0.4xx-xcode14.3 Created! The magic is happening here |
|
/sudo backport release/7.0.2xx-xcode14.3 |
|
Backport Job to branch release/7.0.2xx-xcode14.3 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7610688 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7610687 for more details. |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7610690 for more details. |
…pedNSInputStream. Fixes #15860. (#18020) Preserve all members of WrappedNSInputStream, and mark it as a non-direct binding class, so that the linker doesn't trim away any virtual overrides, since they're actually necessary. Fixes #15860. Backport of #18011 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…pedNSInputStream. Fixes #15860. (#18018) Preserve all members of WrappedNSInputStream, and mark it as a non-direct binding class, so that the linker doesn't trim away any virtual overrides, since they're actually necessary. Fixes #15860. Backport of #18011 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Preserve all members of WrappedNSInputStream, and mark it as a non-direct
binding class, so that the linker doesn't trim away any virtual overrides,
since they're actually necessary.
Fixes #15860.