-
Notifications
You must be signed in to change notification settings - Fork 555
[CFNetwork] Add nullability to forgotten files. #17208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CFNetwork] Add nullability to forgotten files. #17208
Conversation
Add nullability to the files. Although this files won't be present in the new dotnet versions, it is good to add them for classic. Also, if we move all files to have nullability enabled we should be able to pass it as a flag and remove the need to use '#nullable enable' which people can forget.
|
🔥 Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
rolfbjarne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'd like the api diff to confirm no api changes as well (I just re-kicked it).
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
rolfbjarne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API diff looks good!
Add nullability to the files. Although this files won't be present in the new dotnet versions, it is good to add them for classic. Also, if we move all files to have nullability enabled we should be able to pass it as a flag and remove the need to use '#nullable enable' which people can forget.
Add nullability to the files. Although this files won't be present in the new dotnet versions, it is good to add them for classic. Also, if we move all files to have nullability enabled we should be able to pass it as a flag and remove the need to use '#nullable enable' which people can forget.