Skip to content

[src/tests] Fix consistency between ObsoletedOSPlatform and UnsupportedOSPlatform attributes.#17104

Merged
rolfbjarne merged 4 commits into
dotnet:mainfrom
rolfbjarne:cecil-tests-obsolete-unsupported-consistency
Dec 22, 2022
Merged

[src/tests] Fix consistency between ObsoletedOSPlatform and UnsupportedOSPlatform attributes.#17104
rolfbjarne merged 4 commits into
dotnet:mainfrom
rolfbjarne:cecil-tests-obsolete-unsupported-consistency

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

  • If there's both an UnsupportedOSPlatform and ObsoletedOSPlatform attribute with
    the same version, then remove the UnsupportedOSPlatform attribute. This is because
    in the past we used [UnsupportedOSPlatform] + [Obsolete] to indicate that an API
    is obsolete, but then the [ObsoletedOSPlatform] attribute was added, and we replaced
    the [Obsolete] attributes with [ObsoletedOSPlatform] attributes, which makes the
    [UnsupportedOSPlatform] attributes redundant/incorrect.
  • If there's [UnsupportedOSPlatform] with a version or [ObsoletedOSPlatform] with
    a version, then also add [SupportedOSPlatform] in a few cases.
  • If there's an [UnsupportedOSPlatform] with a version for API that's obsolete/non-working,
    then remove the version.

…tedOSPlatform attributes.

* If there's both an UnsupportedOSPlatform and ObsoletedOSPlatform attribute with
  the same version, then remove the UnsupportedOSPlatform attribute. This is because
  in the past we used [UnsupportedOSPlatform] + [Obsolete] to indicate that an API
  is obsolete, but then the [ObsoletedOSPlatform] attribute was added, and we replaced
  the [Obsolete] attributes with [ObsoletedOSPlatform] attributes, which makes the
  [UnsupportedOSPlatform] attributes redundant/incorrect.
* If there's [UnsupportedOSPlatform] with a version or [ObsoletedOSPlatform] with
  a version, then also add [SupportedOSPlatform] in a few cases.
* If there's an [UnsupportedOSPlatform] with a version for API that's obsolete/non-working,
  then remove the version.
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@haritha-mohan
Copy link
Copy Markdown
Contributor

👍

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

📚 [PR Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMBOT-1042.Monterey'
Hash: 3ee43776d966864697af60d8747b29f37ea08a7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3ee43776d966864697af60d8747b29f37ea08a7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: 3ee43776d966864697af60d8747b29f37ea08a7a [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3ee43776d966864697af60d8747b29f37ea08a7a [PR build]

@rolfbjarne rolfbjarne merged commit 491c5c9 into dotnet:main Dec 22, 2022
@rolfbjarne rolfbjarne deleted the cecil-tests-obsolete-unsupported-consistency branch December 22, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants