[src/tests] Fix consistency between ObsoletedOSPlatform and UnsupportedOSPlatform attributes.#17104
Conversation
…tedOSPlatform attributes. * If there's both an UnsupportedOSPlatform and ObsoletedOSPlatform attribute with the same version, then remove the UnsupportedOSPlatform attribute. This is because in the past we used [UnsupportedOSPlatform] + [Obsolete] to indicate that an API is obsolete, but then the [ObsoletedOSPlatform] attribute was added, and we replaced the [Obsolete] attributes with [ObsoletedOSPlatform] attributes, which makes the [UnsupportedOSPlatform] attributes redundant/incorrect. * If there's [UnsupportedOSPlatform] with a version or [ObsoletedOSPlatform] with a version, then also add [SupportedOSPlatform] in a few cases. * If there's an [UnsupportedOSPlatform] with a version for API that's obsolete/non-working, then remove the version.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
👍 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📚 [PR Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1042.Monterey' |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
.NET (No breaking changes)✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 223 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
the same version, then remove the UnsupportedOSPlatform attribute. This is because
in the past we used [UnsupportedOSPlatform] + [Obsolete] to indicate that an API
is obsolete, but then the [ObsoletedOSPlatform] attribute was added, and we replaced
the [Obsolete] attributes with [ObsoletedOSPlatform] attributes, which makes the
[UnsupportedOSPlatform] attributes redundant/incorrect.
a version, then also add [SupportedOSPlatform] in a few cases.
then remove the version.